From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 298721FF56B for ; Mon, 22 Apr 2024 09:29:13 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E42C18CD5; Mon, 22 Apr 2024 09:29:16 +0200 (CEST) Date: Mon, 22 Apr 2024 09:28:43 +0200 (CEST) From: Dietmar Maurer To: Proxmox Backup Server development discussion , Hannes Laimer Message-ID: <2660798.9067.1713770923522@webmail.proxmox.com> In-Reply-To: <20240419155606.112010-7-h.laimer@proxmox.com> References: <20240419155606.112010-1-h.laimer@proxmox.com> <20240419155606.112010-7-h.laimer@proxmox.com> MIME-Version: 1.0 X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev61 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.349 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v8 06/23] api: removable datastore creation X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" comments inline > /// Create new datastore config. > pub fn create_datastore( > - config: DataStoreConfig, > + mut config: DataStoreConfig, > rpcenv: &mut dyn RpcEnvironment, > ) -> Result { > let lock = pbs_config::datastore::lock_config()?; > @@ -122,6 +149,31 @@ pub fn create_datastore( > param_bail!("name", "datastore '{}' already exists.", config.name); > } > > + if let Some(uuid) = &config.backing_device { > + let already_used_by = section_config > + .sections > + .iter() > + .flat_map(|(datastore_name, (_, config))| { > + config > + .as_object() > + .and_then(|cfg| cfg.get("backing-device")) > + .and_then(|backing_device| backing_device.as_str()) > + .filter(|&device_uuid| device_uuid == uuid) > + .map(|_| datastore_name) > + }) > + .next(); > + > + if let Some(datastore_name) = already_used_by { > + param_bail!( > + "backing-device", > + "device already in use by datastore '{datastore_name}'", > + ); > + } > + if let Some(mount_point) = config.get_mount_point() { > + config.path = format!("{mount_point}/{}", config.path.trim_start_matches('/')); This looks redundant for me. I don't want to store the mount point in the datastore path. > + } > + } > + > let auth_id: Authid = rpcenv.get_auth_id().unwrap().parse()?; > let to_stdout = rpcenv.env_type() == RpcEnvironmentType::CLI; > > -- > 2.39.2 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel