From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 92D24A0834 for ; Thu, 9 Nov 2023 10:34:44 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 725EC12857 for ; Thu, 9 Nov 2023 10:34:44 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 9 Nov 2023 10:34:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B74294756E for ; Thu, 9 Nov 2023 10:34:43 +0100 (CET) Message-ID: <262e08b9-b378-449e-9680-98f818edcad9@proxmox.com> Date: Thu, 9 Nov 2023 10:34:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Backup Server development discussion , Hannes Laimer References: <20231006140529.723988-1-h.laimer@proxmox.com> <20231006140529.723988-7-h.laimer@proxmox.com> Content-Language: en-US From: Gabriel Goller In-Reply-To: <20231006140529.723988-7-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.257 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup v5 6/6] ui: add support for optional Remote in SyncJob X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Nov 2023 09:34:44 -0000 Hi! I tested it a bit and it looks good so far, a few small ui issues though: * When listing the sync-jobs, a local sync job has an empty 'Remote ID', which     doesn't look that good. We could add a defaultValue that shows 'Local' or     something? * We don't support syncs from and to the same datastore, so it also shouldn't be     allowed to select it in the ui. Currently all the datastores are shown on the     dropdown. These syncs also run successfully but don't sync anything, we should     probably throw an error in the api if such a sync is requested. So that ui and     api disallow same-datastore syncs. On 10/6/23 16:05, Hannes Laimer wrote: > Signed-off-by: Hannes Laimer > --- > www/form/RemoteTargetSelector.js | 29 ++++++++----- > www/window/SyncJobEdit.js | 72 +++++++++++++++++++++++++++++++- > 2 files changed, 90 insertions(+), 11 deletions(-) > [..]