From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 55B6D1FF136 for ; Mon, 04 May 2026 10:11:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 26D081608B; Mon, 4 May 2026 10:11:56 +0200 (CEST) Message-ID: <2605af59-0107-49fe-ab67-ccf5cd6a21f4@proxmox.com> Date: Mon, 4 May 2026 10:11:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox-backup 2/2] ui: GC/prune: pass tasks last run endtime to task viewer To: Thomas Lamprecht , pbs-devel@lists.proxmox.com References: <20260430121015.528664-1-c.ebner@proxmox.com> <20260430121015.528664-3-c.ebner@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777882175904 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.070 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ARHAFDGAQE766LELJN6REVQ53IHCVBDB X-Message-ID-Hash: ARHAFDGAQE766LELJN6REVQ53IHCVBDB X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 5/4/26 10:01 AM, Thomas Lamprecht wrote: > Am 30.04.26 um 14:09 schrieb Christian Ebner: >> Same issue as tackled by commit e8552dae3 ("ui: sync/verify view: >> show correct duration in task log window"), pass the last run >> endtime to the task log window for correct calculation of the >> job duration for finished jobs, not using the current time. >> >> For correctly showing the verification task status in datastore >> contents, an additional API request is required first to get the >> endtime. Other call sites arelady have the required information. >> >> Fixes: https://forum.proxmox.com/threads/183157/ >> Signed-off-by: Christian Ebner > > AFAICT this can be handled in widget-toolkit without extra (blocking) > calls here on api task open, as it shouldn't hurt I pushed out already > a proposed change here: > > https://git.proxmox.com/?p=proxmox-widget-toolkit.git;a=commitdiff;h=7431c0766f0439481ae17ef54f49ee8edc210069 Nice, thanks for the heads up! Will double check the behavior after these changes.