From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AC516B95BA for ; Thu, 14 Mar 2024 09:00:18 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8BB6585E9 for ; Thu, 14 Mar 2024 08:59:48 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 14 Mar 2024 08:59:47 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4DBBE489C1; Thu, 14 Mar 2024 08:59:47 +0100 (CET) Message-ID: <2524761d-e6b9-4d89-84ef-03d261029f92@proxmox.com> Date: Thu, 14 Mar 2024 08:59:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox Backup Server development discussion , Gabriel Goller References: <20240313161801.132483-1-g.goller@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20240313161801.132483-1-g.goller@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.019 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/2] gui: remove document.execCommand calls X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Mar 2024 08:00:18 -0000 hi, just to note: changing to an async function can be rather dangerous, sometimes extjs not only calls the handlers/events/etc. but does things after them (expecting the function to be finished) or waits for the return value. (most of the extjs code was from before async/await was a thing in js) so here it seems to work out fine, but we have to be careful with sprinkling async function in the code, otherwise we'll get very unexpected results in general, i'd like to see that mentioned in the commit message why it's ok to do that (no hard feelings though) otherwise LGTM