From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D7BB4608F4 for ; Thu, 10 Sep 2020 07:49:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C594918301 for ; Thu, 10 Sep 2020 07:49:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A185C182F2 for ; Thu, 10 Sep 2020 07:49:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6853F44AED for ; Thu, 10 Sep 2020 07:49:19 +0200 (CEST) Date: Thu, 10 Sep 2020 07:48:34 +0200 (CEST) From: Dietmar Maurer To: Proxmox Backup Server development discussion , Hannes Laimer Message-ID: <251922008.1099.1599716915388@webmail.proxmox.com> In-Reply-To: <20200902094122.104475-2-h.laimer@proxmox.com> References: <20200902094122.104475-1-h.laimer@proxmox.com> <20200902094122.104475-2-h.laimer@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.3-Rev21 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.079 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH v1 proxmox-backup] add benchmark flag to backup creation for proper cleanup when running a benchmark X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Sep 2020 05:49:20 -0000 some comment: @@ -118,10 +118,8 @@ async move { let (path, is_new, _snap_guard) = datastore.create_locked_backup_dir(&backup_dir)?; if !is_new { bail!("backup directory already exists."); } let absolute_backup_dir_path = format!("{}/{}", &datastore.base_path().to_str().unwrap(), backup_group); - let mut worker_type = "backup"; - if benchmark { - worker_type = "benchmark"; - } + let worker_type = if benchmark { "benchmark" } else { "backup" }; + WorkerTask::spawn(worker_type, Some(worker_id), userid.clone(), true, move |worker| { let mut env = BackupEnvironment::new( env_type, userid, worker.clone(), datastore, backup_dir); On 09/02/2020 11:41 AM Hannes Laimer wrote: > > > Signed-off-by: Hannes Laimer > --- > v1: > - set worker_type to 'benchmark', if it is one > - delete whole '/host/benchmark'-folder after benchmark This is super dangerous, because you delete the whole group now, i.e: you can do the following run job /vm/12345 --benchmark which completely removes all you VM backups?!