From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BEC7093385 for ; Fri, 16 Sep 2022 12:16:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B3D312262E for ; Fri, 16 Sep 2022 12:16:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 16 Sep 2022 12:16:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AB17D4042F for ; Fri, 16 Sep 2022 12:08:40 +0200 (CEST) Message-ID: <241b9a11-6efb-4f1b-e87d-e6b727b84a7a@proxmox.com> Date: Fri, 16 Sep 2022 12:08:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Content-Language: en-US To: pbs-devel@lists.proxmox.com, Matthias Heiserer References: <20220914105039.186907-1-m.heiserer@proxmox.com> From: Fiona Ebner In-Reply-To: <20220914105039.186907-1-m.heiserer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.947 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.816 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/2] prune-simulator: allow setting a date on which prune happens X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2022 10:16:50 -0000 Nit: maybe use "allow setting a custom date" for the commit title. It affects the simulated schedule too, not just pruning. Am 14.09.22 um 12:50 schrieb Matthias Heiserer: > With this applied, the prune simulator will be more flexible, which might clear > up questions such as these: > https://forum.proxmox.com/threads/pbs-prune-simulator-monthly-backups.115081 > > In order to have the configuration window not take up too much space, > I added another column and moved the border slightly to the left, so the options > part looks off-centered. > For me, the right side of the time fields is cut off for both new options (both in Firefox and Chromium). > Signed-off-by: Matthias Heiserer > --- > .../prune-simulator/prune-simulator_source.js | 92 ++++++++++++------- > 1 file changed, 58 insertions(+), 34 deletions(-) > > diff --git a/docs/prune-simulator/prune-simulator_source.js b/docs/prune-simulator/prune-simulator_source.js > index 84d3461c..137cf1b3 100644 > --- a/docs/prune-simulator/prune-simulator_source.js > +++ b/docs/prune-simulator/prune-simulator_source.js > @@ -330,6 +330,8 @@ Ext.onReady(function() { > > let params = view.getValues(); > > + NOW.setTime(Date.parse(params.currentDate)); NOW is currently declared as const and I guess it works, because it's a Date object, but I'd rather just drop the variable and add a viewModel entry instead. That also avoids a (I guess irrelevant in practice) race between the "new Date()" calls for the two new timefields. If it makes things easier, feel free to combine the patches into one.