From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BA2FF759DE for ; Tue, 13 Jul 2021 12:47:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A535E21A74 for ; Tue, 13 Jul 2021 12:47:01 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 31D141797D for ; Tue, 13 Jul 2021 12:45:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 46FA841042 for ; Tue, 13 Jul 2021 12:45:23 +0200 (CEST) Message-ID: <2407d0ea-b1f9-433f-50a7-fbcebe2ae3c3@proxmox.com> Date: Tue, 13 Jul 2021 12:45:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Dominik Csapak References: <20210712115435.117447-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210712115435.117447-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.193 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.479 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] ui: NodeInfo: add link to repositories X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jul 2021 10:47:31 -0000 On 12.07.21 13:54, Dominik Csapak wrote: > to guide the user to the repository panel from the dashboard > > Signed-off-by: Dominik Csapak > --- > www/panel/NodeInfo.js | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/www/panel/NodeInfo.js b/www/panel/NodeInfo.js > index ff96e8fc..d05a53d1 100644 > --- a/www/panel/NodeInfo.js > +++ b/www/panel/NodeInfo.js > @@ -46,7 +46,9 @@ Ext.define('PBS.NodeInfoPanel', { > }, > repoStatusMessage: function(get) { > const status = get('repoStatus'); > - return Proxmox.Utils.formatNodeRepoStatus(status, 'Proxmox Backup Server'); > + let link = '#pbsServerAdministration:aptrepositories'; > + let icon = ` `; avoid over-general variable names, `repoLink` (and the link inline). But actually I do not like this being a normal link, which gets purple once visited. Also the symbol isn't really clear in this context, a `fa-arrow-circle-o-right` could be easier to get the "goto" meaning, then some hover feedback would be also good (if we keep this icon only I'd do similar to what we do for the action-column icons in the datastore content panel. A tooltip could then be good to, to underline what this clickable element actually does. > + return Proxmox.Utils.formatNodeRepoStatus(status, 'Proxmox Backup Server') + icon; > }, > }, > }, >