From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dietmar@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 67C416AE91
 for <pbs-devel@lists.proxmox.com>; Wed, 17 Feb 2021 12:14:22 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 582A62123F
 for <pbs-devel@lists.proxmox.com>; Wed, 17 Feb 2021 12:13:52 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id EDED721232
 for <pbs-devel@lists.proxmox.com>; Wed, 17 Feb 2021 12:13:51 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B0ED5461CE
 for <pbs-devel@lists.proxmox.com>; Wed, 17 Feb 2021 12:13:51 +0100 (CET)
Date: Wed, 17 Feb 2021 12:13:08 +0100 (CET)
From: Dietmar Maurer <dietmar@proxmox.com>
To: Stefan Reiter <s.reiter@proxmox.com>,
 Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>
Message-ID: <2115275326.3071.1613560389065@webmail.proxmox.com>
In-Reply-To: <d06c4bd3-708f-4120-e7ad-b732441d0de3@proxmox.com>
References: <20210216170710.31767-1-s.reiter@proxmox.com>
 <20210216170710.31767-16-s.reiter@proxmox.com>
 <38278034.3068.1613557520535@webmail.proxmox.com>
 <d06c4bd3-708f-4120-e7ad-b732441d0de3@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Priority: 3
Importance: Normal
X-Mailer: Open-Xchange Mailer v7.10.4-Rev16
X-Originating-Client: open-xchange-appsuite
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.120 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup 15/22] file-restore-daemon:
 add binary with virtio-vsock API server
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 17 Feb 2021 11:14:22 -0000


> On 02/17/2021 11:30 AM Stefan Reiter <s.reiter@proxmox.com> wrote:
> 
>  
> On 17/02/2021 11:25, Dietmar Maurer wrote:
> >> Since the REST server implementation uses the log!() macro, we can
> >> redirect its output to stdout by registering env_logger as the logging
> >> target. env_logger is already in our dependency tree via zstd/bindgen.
> > 
> > Initializing the syslog crate should be enough:
> > 
> >     if let Err(err) = syslog::init(
> >          syslog::Facility::LOG_DAEMON,
> >          log::LevelFilter::Info,
> >          Some("file-restore-daemon")) {
> >          bail!("unable to inititialize syslog - {}", err);
> >      }
> > 
> 
> Wouldn't the syslog crate depend on the systemd journal though? Or does 
> it fall back to stdout/stderr?

Ah, I see - we do not have syslog running.

I guess its Ok to use env_logger then.