From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 90B7FB8DE3 for ; Mon, 11 Mar 2024 16:51:16 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6784FCC33 for ; Mon, 11 Mar 2024 16:51:16 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 11 Mar 2024 16:51:15 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 268ED488D7 for ; Mon, 11 Mar 2024 16:51:15 +0100 (CET) Date: Mon, 11 Mar 2024 16:51:14 +0100 (CET) From: Christian Ebner To: =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= , Proxmox Backup Server development discussion Message-ID: <205664376.11028.1710172274507@webmail.proxmox.com> In-Reply-To: <1710169433.csk298bchf.astroid@yuna.none> References: <20240305092703.126906-1-c.ebner@proxmox.com> <20240305092703.126906-5-c.ebner@proxmox.com> <1710153663.gtljd8y4z5.astroid@yuna.none> <1081076067.10791.1710165903108@webmail.proxmox.com> <1710169433.csk298bchf.astroid@yuna.none> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev59 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.038 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [RFC v2 pxar 04/36] decoder: add optional payload input stream X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Mar 2024 15:51:16 -0000 > On 11.03.2024 16:27 CET Fabian Gr=C3=BCnbichler wrote: >=20 > > Good, this will come in handy as Dietmar also suggested to add a header= for > > all the payloads stored in the separated payload archive. I plan on usi= ng the > > existing PXAR_PAYLOAD header for this, also encoding the payload size. = I will > > therefore add a check for the header here and compare the sizes as foun= d in > > the payload input and metadata archives. >=20 > out of intereset - what do we need the header for? or is it just to make > the resulting payload archive more debuggable? >=20 For consistency checks, so one can verify in the decoder that the payload reference offset correctly points to the start of a file payload.