From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 5C6F11FF0B4 for ; Tue, 10 Nov 2026 16:37:58 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 1138121620; Tue, 10 Nov 2026 16:37:58 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup v2 1/5] verify: drop useless try_block! in snapshot verification Date: Tue, 10 Nov 2026 16:37:27 +0100 Message-ID: <20261110153731.449671-2-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261110153731.449671-1-c.ebner@proxmox.com> References: <20261110153731.449671-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794325074214 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.429 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: MAV5HSB7TMZDZXJLSHTLVGOD7IP475VT X-Message-ID-Hash: MAV5HSB7TMZDZXJLSHTLVGOD7IP475VT X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Not needed and makes the code more concise as well as better readable because of the reduced nesting level. No functional changes. Signed-off-by: Christian Ebner --- src/backup/verify.rs | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/backup/verify.rs b/src/backup/verify.rs index 43bee6a36..18fb1ca4c 100644 --- a/src/backup/verify.rs +++ b/src/backup/verify.rs @@ -441,14 +441,12 @@ impl VerifyWorker { let mut verify_result = VerifyState::Ok; for info in manifest.files() { - let result = proxmox_lang::try_block!({ - info!(" check {}", info.filename); - match info.filename.archive_type() { - ArchiveType::FixedIndex => self.verify_fixed_index(backup_dir, info), - ArchiveType::DynamicIndex => self.verify_dynamic_index(backup_dir, info), - ArchiveType::Blob => Self::verify_blob(backup_dir, info), - } - }); + info!(" check {}", info.filename); + let result = match info.filename.archive_type() { + ArchiveType::FixedIndex => self.verify_fixed_index(backup_dir, info), + ArchiveType::DynamicIndex => self.verify_dynamic_index(backup_dir, info), + ArchiveType::Blob => Self::verify_blob(backup_dir, info), + }; self.worker.check_abort()?; self.worker.fail_on_shutdown()?; -- 2.47.3