From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 788EC1FF0B6 for ; Wed, 30 Sep 2026 17:22:39 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 474EC21682; Wed, 30 Sep 2026 17:22:39 +0200 (CEST) From: Jonas Theisen To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup 13/14] fix #7904: Remove clear button from calendar selector Date: Wed, 30 Sep 2026 17:18:11 +0200 Message-ID: <20260930152131.317493-14-j.theisen@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260930152131.317493-1-j.theisen@proxmox.com> References: <20260930152131.317493-1-j.theisen@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1790781754374 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.205 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BO7Y3P33CQCALHBZFSCBYJO2E3W44QPR X-Message-ID-Hash: BO7Y3P33CQCALHBZFSCBYJO2E3W44QPR X-MailFrom: j.theisen@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Since the schedule fields in all the forms do not allow empty inputs anymore it would be unintuitive to have a clear button. This patch removes the trigger and listener logic for that. Can be seen optional and is not needed to fix #7904 Signed-off-by: Jonas Theisen --- www/form/CalendarEvent.js | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/www/form/CalendarEvent.js b/www/form/CalendarEvent.js index b050da694..d6cc6e0e9 100644 --- a/www/form/CalendarEvent.js +++ b/www/form/CalendarEvent.js @@ -53,25 +53,6 @@ Ext.define('PBS.form.CalendarEvent', { return data; }, - triggers: { - clear: { - cls: 'pmx-clear-trigger', - weight: -1, - hidden: true, - handler: function () { - this.triggers.clear.setVisible(false); - this.setValue(''); - }, - }, - }, - - listeners: { - change: function (field, value) { - let canClear = (value ?? '') !== ''; - field.triggers.clear.setVisible(canClear); - }, - }, - store: { type: 'calendarEventExamples', }, -- 2.47.3