From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 65A0E1FF0E7 for ; Thu, 13 Aug 2026 19:11:45 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 9259A21B9E; Thu, 13 Aug 2026 19:11:15 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup 27/28] api: admin: allow to update snapshot retention for root user Date: Thu, 13 Aug 2026 19:10:01 +0200 Message-ID: <20260813171002.809441-28-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260813171002.809441-1-c.ebner@proxmox.com> References: <20260813171002.809441-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1786641019044 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.194 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WWKHDJSZ7MH3WPYHVEGWWHSNPNWOHWTC X-Message-ID-Hash: WWKHDJSZ7MH3WPYHVEGWWHSNPNWOHWTC X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Only root user should be able to ever modify the retention setting set by the sync/backup api. Signed-off-by: Christian Ebner --- src/api2/admin/datastore.rs | 53 ++++++++++++++++++++++++++++++++++++- 1 file changed, 52 insertions(+), 1 deletion(-) diff --git a/src/api2/admin/datastore.rs b/src/api2/admin/datastore.rs index bb829cd3f..244320989 100644 --- a/src/api2/admin/datastore.rs +++ b/src/api2/admin/datastore.rs @@ -45,7 +45,7 @@ use pbs_api_types::{ MaintenanceMode, MaintenanceType, NS_MAX_DEPTH_SCHEMA, Operation, PRIV_DATASTORE_AUDIT, PRIV_DATASTORE_BACKUP, PRIV_DATASTORE_MODIFY, PRIV_DATASTORE_PRUNE, PRIV_DATASTORE_READ, PRIV_DATASTORE_VERIFY, PRIV_SYS_MODIFY, PruneJobOptions, SnapshotListItem, SyncJobConfig, UPID, - UPID_SCHEMA, VERIFICATION_OUTDATED_AFTER_SCHEMA, VERIFY_JOB_READ_THREADS_SCHEMA, + UPID_SCHEMA, Userid, VERIFICATION_OUTDATED_AFTER_SCHEMA, VERIFY_JOB_READ_THREADS_SCHEMA, VERIFY_JOB_VERIFY_THREADS_SCHEMA, print_ns_and_snapshot, print_store_and_ns, }; use pbs_client::pxar::{create_tar, create_zip}; @@ -2319,6 +2319,56 @@ pub async fn set_protection( .await? } +#[api( + input: { + properties: { + store: { schema: DATASTORE_SCHEMA }, + ns: { + type: BackupNamespace, + optional: true, + }, + backup_dir: { + type: pbs_api_types::BackupDir, + flatten: true, + }, + "retain-until": { + type: Number, + description: "Set retention timestamp (clears retention if not given)", + optional: true, + }, + }, + }, + access: { + permission: &Permission::Anybody, + description: "Only root@pam is allowed to modify retentions", + }, +)] +/// Set retention for a specific already existing backup +pub fn set_retention( + store: String, + ns: Option, + backup_dir: pbs_api_types::BackupDir, + retain_until: Option, + rpcenv: &mut dyn RpcEnvironment, +) -> Result<(), Error> { + let auth_id: Authid = rpcenv.get_auth_id().unwrap().parse()?; + if auth_id.is_token() || auth_id.user() != Userid::root_userid() { + bail!("only root can modifiy snapshot retention"); + } + + let datastore = DataStore::lookup_datastore(lookup_with(&store, Operation::Write))?; + let backend = datastore.backend()?; + let ns = ns.unwrap_or_default(); + let backup_dir = datastore.backup_dir(ns, backup_dir)?; + backup_dir + .update_manifest(&backend, |manifest| { + manifest.add_retention_timestamp(retain_until); + }) + .map_err(|err| format_err!("failed to set retention timestamp on manifest: {err}"))?; + + Ok(()) +} + #[api( input: { properties: { @@ -2994,6 +3044,7 @@ const DATASTORE_INFO_SUBDIRS: SubdirMap = &[ "pxar-file-download", &Router::new().download(&API_METHOD_PXAR_FILE_DOWNLOAD), ), + ("retention", &Router::new().put(&API_METHOD_SET_RETENTION)), ("rrd", &Router::new().get(&API_METHOD_GET_RRD_STATS)), ("s3-refresh", &Router::new().put(&API_METHOD_S3_REFRESH)), ( -- 2.47.3