From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id A702B1FF0E7 for ; Thu, 13 Aug 2026 19:11:03 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 1D0FD21B03; Thu, 13 Aug 2026 19:10:37 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup 13/28] api: sync: allow pull to target for user/token with append permission Date: Thu, 13 Aug 2026 19:09:47 +0200 Message-ID: <20260813171002.809441-14-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260813171002.809441-1-c.ebner@proxmox.com> References: <20260813171002.809441-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1786641015677 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.210 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: CL3PMPKM6FTE7Y7S5RXDTFT6DHZHXRCW X-Message-ID-Hash: CL3PMPKM6FTE7Y7S5RXDTFT6DHZHXRCW X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Allows appending new backup groups/snapshots to the target datastore on syncs in pull direction if the user/token has append permissions and is owner of the backups. Signed-off-by: Christian Ebner --- src/api2/config/sync.rs | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/api2/config/sync.rs b/src/api2/config/sync.rs index d0e678220..ac1039064 100644 --- a/src/api2/config/sync.rs +++ b/src/api2/config/sync.rs @@ -7,10 +7,10 @@ use proxmox_router::{Permission, Router, RpcEnvironment, http_bail}; use proxmox_schema::{api, param_bail}; use pbs_api_types::{ - Authid, JOB_ID_SCHEMA, PRIV_DATASTORE_AUDIT, PRIV_DATASTORE_BACKUP, PRIV_DATASTORE_MODIFY, - PRIV_DATASTORE_PRUNE, PRIV_DATASTORE_READ, PRIV_REMOTE_AUDIT, PRIV_REMOTE_DATASTORE_BACKUP, - PRIV_REMOTE_DATASTORE_PRUNE, PRIV_REMOTE_READ, PROXMOX_CONFIG_DIGEST_SCHEMA, SyncJobConfig, - SyncJobConfigUpdater, + Authid, JOB_ID_SCHEMA, PRIV_DATASTORE_APPEND, PRIV_DATASTORE_AUDIT, PRIV_DATASTORE_BACKUP, + PRIV_DATASTORE_MODIFY, PRIV_DATASTORE_PRUNE, PRIV_DATASTORE_READ, PRIV_REMOTE_AUDIT, + PRIV_REMOTE_DATASTORE_BACKUP, PRIV_REMOTE_DATASTORE_PRUNE, PRIV_REMOTE_READ, + PROXMOX_CONFIG_DIGEST_SCHEMA, SyncJobConfig, SyncJobConfigUpdater, }; use pbs_config::sync; @@ -99,7 +99,9 @@ pub fn check_sync_job_modify_access( } // creating backups on target check - if ns_anchor_privs & PRIV_DATASTORE_BACKUP == 0 { + if ns_anchor_privs & PRIV_DATASTORE_BACKUP == 0 + && ns_anchor_privs & PRIV_DATASTORE_APPEND == 0 + { return false; } -- 2.47.3