From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 83A931FF0E6 for ; Fri, 07 Aug 2026 11:58:34 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 34B9221541; Fri, 07 Aug 2026 11:58:34 +0200 (CEST) From: Robert Obkircher To: pbs-devel@lists.proxmox.com Subject: [PATCH v1 proxmox-backup 0/2] minor chunk insert improvements Date: Fri, 7 Aug 2026 11:57:58 +0200 Message-ID: <20260807095803.3051-1-r.obkircher@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1786096695812 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.928 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: DB5PA377R5YYFNZBNDRZTJEM4WMZMEYY X-Message-ID-Hash: DB5PA377R5YYFNZBNDRZTJEM4WMZMEYY X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Improve error messages and avoid custom unsafe code. I forgot to send these patches from about 2 months ago. At the time Fabian suggested that we could potentially remove the read entirely and simply ignore these collisions. Robert Obkircher (2): datastore: prefer standard library over custom unsafe code datastore: rephrase error messages for failed chunk insert pbs-datastore/src/chunk_store.rs | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) -- 2.47.3