From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id D5D491FF126 for ; Mon, 03 Aug 2026 11:08:08 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 23C69214A9; Mon, 03 Aug 2026 11:08:08 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup v4 02/14] api: config: early perform user access checks for datastore creation Date: Mon, 3 Aug 2026 11:07:35 +0200 Message-ID: <20260803090747.265683-3-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260803090747.265683-1-c.ebner@proxmox.com> References: <20260803090747.265683-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785748072563 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.210 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: T2AOS6GKKU4USESML2BPHEGTLQ5HYT64 X-Message-ID-Hash: T2AOS6GKKU4USESML2BPHEGTLQ5HYT64 X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: If the user is lacking permissions to perform the requested actions, locking the datastore config must be avoided altogether. Signed-off-by: Christian Ebner --- src/api2/config/datastore.rs | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/api2/config/datastore.rs b/src/api2/config/datastore.rs index e7028480c..76e784e5a 100644 --- a/src/api2/config/datastore.rs +++ b/src/api2/config/datastore.rs @@ -276,6 +276,14 @@ pub fn create_datastore( overwrite_in_use: bool, rpcenv: &mut dyn RpcEnvironment, ) -> Result { + let auth_id: Authid = rpcenv.get_auth_id().unwrap().parse()?; + let to_stdout = rpcenv.env_type() == RpcEnvironmentType::CLI; + + if config.backing_device.is_some() { + let user_info = CachedUserInfo::new()?; + user_info.check_privs(&auth_id, &["system", "disks"], PRIV_SYS_MODIFY, false)?; + } + let lock = pbs_config::datastore::lock_config()?; let (section_config, _digest) = pbs_config::datastore::config()?; @@ -302,14 +310,6 @@ pub fn create_datastore( param_bail!("gc-on-unmount", "only supported on removable datastores",); } - let auth_id: Authid = rpcenv.get_auth_id().unwrap().parse()?; - let to_stdout = rpcenv.env_type() == RpcEnvironmentType::CLI; - - if config.backing_device.is_some() { - let user_info = CachedUserInfo::new()?; - user_info.check_privs(&auth_id, &["system", "disks"], PRIV_SYS_MODIFY, false)?; - } - let mut prune_job_config = None; if config.keep.keeps_something() || !has_prune_job(&config.name)? { prune_job_config = config.prune_schedule.as_ref().map(|schedule| { -- 2.47.3