From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 206211FF126 for ; Fri, 31 Jul 2026 16:25:11 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 3BEEF21579; Fri, 31 Jul 2026 16:25:09 +0200 (CEST) From: Robert Obkircher To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup 2/9] datastore: limit scope of mutable reference in FixedIndexWriter::close Date: Fri, 31 Jul 2026 16:21:15 +0200 Message-ID: <20260731142430.289893-3-r.obkircher@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260731142430.289893-1-r.obkircher@proxmox.com> References: <20260731142430.289893-1-r.obkircher@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785507896810 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.153 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: MLVN3LEHCYCMU67LZ555FTIU3H7JB32T X-Message-ID-Hash: MLVN3LEHCYCMU67LZ555FTIU3H7JB32T X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Eliminate the variable to make it clearer that the reference won't be accessed after the memory is unmapped. Signed-off-by: Robert Obkircher --- pbs-datastore/src/fixed_index.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pbs-datastore/src/fixed_index.rs b/pbs-datastore/src/fixed_index.rs index b516bad62..2324fc3e0 100644 --- a/pbs-datastore/src/fixed_index.rs +++ b/pbs-datastore/src/fixed_index.rs @@ -464,8 +464,9 @@ impl FixedIndexWriter { }; let index_size = self.index_length * 32; - let data = unsafe { std::slice::from_raw_parts(ptr.index().as_ptr(), index_size) }; - let index_csum = openssl::sha::sha256(data); + let index_csum = openssl::sha::sha256(unsafe { + std::slice::from_raw_parts(ptr.index().as_ptr(), index_size) + }); { let header = unsafe { ptr.header().as_mut() }; -- 2.47.3