From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 9C55B1FF0E2 for ; Thu, 30 Jul 2026 15:32:29 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 9F11A2158D; Thu, 30 Jul 2026 15:32:15 +0200 (CEST) From: Shannon Sterz To: pbs-devel@lists.proxmox.com Subject: [PATCH datacenter-manager 11/16] certs: use proxmox-tls-certificates directly, add days_valid paramter Date: Thu, 30 Jul 2026 15:31:53 +0200 Message-ID: <20260730133158.418015-12-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260730133158.418015-1-s.sterz@proxmox.com> References: <20260730133158.418015-1-s.sterz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785418313940 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.132 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GZJVTV6LLORM3QGDXJRSYYFUHDIX656Y X-Message-ID-Hash: GZJVTV6LLORM3QGDXJRSYYFUHDIX656Y X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: instead of using it through proxmox-acme-api. chosing `None` as days valid parameter makes the certificate valid for 3650 days, almost ten years. Signed-off-by: Shannon Sterz --- Cargo.toml | 2 ++ debian/control | 2 ++ server/Cargo.toml | 1 + server/src/auth/certs.rs | 3 ++- 4 files changed, 7 insertions(+), 1 deletion(-) diff --git a/Cargo.toml b/Cargo.toml index b5916b36..952a9573 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -66,6 +66,7 @@ proxmox-sys = "1" proxmox-systemd = "1" proxmox-tfa = { version = "6", features = [ "api-types" ], default-features = false } proxmox-time = "2" +proxmox-tls-certificates = { version = "1", features = [ "impl" ] } proxmox-upgrade-checks = "1" proxmox-uuid = "1" proxmox-installer-types = "0.1" @@ -184,6 +185,7 @@ zstd = { version = "0.13" } # proxmox-tfa = { path = "../proxmox/proxmox-tfa" } # proxmox-time-api = { path = "../proxmox/proxmox-time-api" } # proxmox-time = { path = "../proxmox/proxmox-time" } +# proxmox-tls-certificates = { path = "../proxmox/proxmox-tls-certificates" } # proxmox-upgrade-checks = { path = "../proxmox/proxmox-upgrade-checks" } # proxmox-uuid = { path = "../proxmox/proxmox-uuid" } # proxmox-worker-task = { path = "../proxmox/proxmox-worker-task" } diff --git a/debian/control b/debian/control index e1430dca..5bd6ef8e 100644 --- a/debian/control +++ b/debian/control @@ -111,6 +111,8 @@ Build-Depends: debhelper-compat (= 13), librust-proxmox-time-2+default-dev, librust-proxmox-time-api-1+default-dev, librust-proxmox-time-api-1+impl-dev, + librust-proxmox-tls-certificates-1+default-dev, + librust-proxmox-tls-certificates-1+impl-dev, librust-proxmox-upgrade-checks-1+default-dev, librust-proxmox-uuid-1+default-dev, librust-pve-api-types-8+client-dev (>= 8.1.12-~~), diff --git a/server/Cargo.toml b/server/Cargo.toml index 663f21cb..d70e1d11 100644 --- a/server/Cargo.toml +++ b/server/Cargo.toml @@ -64,6 +64,7 @@ proxmox-sys = { workspace = true, features = [ "timer" ] } proxmox-systemd.workspace = true proxmox-tfa = { workspace = true, features = [ "api" ] } proxmox-time.workspace = true +proxmox-tls-certificates = { workspace = true, features = [ "impl" ]} proxmox-uuid.workspace = true proxmox-apt = { workspace = true, features = [ "cache" ] } diff --git a/server/src/auth/certs.rs b/server/src/auth/certs.rs index 49b2076b..c208cf4f 100644 --- a/server/src/auth/certs.rs +++ b/server/src/auth/certs.rs @@ -19,10 +19,11 @@ pub fn update_self_signed_cert(force: bool) -> Result<(), Error> { let resolv_conf = read_etc_resolv_conf(None)?.config; - let (priv_key, cert) = proxmox_acme_api::create_self_signed_cert( + let (priv_key, cert) = proxmox_tls_certificates::create_self_signed_cert( "Proxmox Datacenter Manager", proxmox_sys::nodename(), resolv_conf.search.as_deref(), + None, )?; let cert_pem = cert.to_pem()?; -- 2.47.3