From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id A73401FF0E5 for ; Wed, 29 Jul 2026 11:08:22 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 794EE2143D; Wed, 29 Jul 2026 11:08:22 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup v3 3/5] client: backup writer: pass no crypt config to manifest blob decoder Date: Wed, 29 Jul 2026 11:07:35 +0200 Message-ID: <20260729090737.135385-4-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260729090737.135385-1-c.ebner@proxmox.com> References: <20260729090737.135385-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785316034483 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.147 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NTUNKTO7U2W2ZXXIFCDT22NWVA4YBZFW X-Message-ID-Hash: NTUNKTO7U2W2ZXXIFCDT22NWVA4YBZFW X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Data blobs storing a manifest are never encrypted, so passing the backup writer crypt config on DataBlob::decode() while fetching the previous manifest is useless, never used in that case anyways. Simply do not pass the crypt config to make the code semantically correct. No functional changes intended. Signed-off-by: Christian Ebner Reviewed-by: Robert Obkircher --- pbs-client/src/backup_writer.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pbs-client/src/backup_writer.rs b/pbs-client/src/backup_writer.rs index f0744ecaf..f1003f800 100644 --- a/pbs-client/src/backup_writer.rs +++ b/pbs-client/src/backup_writer.rs @@ -747,8 +747,8 @@ impl BackupWriter { .await?; let blob = DataBlob::load_from_reader(&mut &raw_data[..])?; - // no expected digest available - let data = blob.decode(self.crypt_config.as_ref().map(Arc::as_ref), None)?; + // manifest blobs are never encrypted and no expected digest available + let data = blob.decode(None, None)?; let manifest = BackupManifest::from_data(&data[..], self.crypt_config.as_ref().map(Arc::as_ref))?; -- 2.47.3