From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 754551FF0E6 for ; Fri, 24 Jul 2026 13:09:30 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 1466321493; Fri, 24 Jul 2026 13:09:30 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox v4 1/3] rest-server: add request logfilter by method and path in h2 service Date: Fri, 24 Jul 2026 13:07:33 +0200 Message-ID: <20260724110735.464113-2-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260724110735.464113-1-c.ebner@proxmox.com> References: <20260724110735.464113-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784891304742 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.163 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3VOZHSILUUMN6NV2Y2QQPAYTJ53KMVPS X-Message-ID-Hash: 3VOZHSILUUMN6NV2Y2QQPAYTJ53KMVPS X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Allows to optionally filter incoming requests to be excluded from the task log. The filter method is provided on instantiation and passes the request method and path. A first usecase for this is to filter out HTTP level heartbeat requests send by the client's backup reader/writer implementation in order to avoid log flodding. Signed-off-by: Christian Ebner --- proxmox-rest-server/src/h2service.rs | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/proxmox-rest-server/src/h2service.rs b/proxmox-rest-server/src/h2service.rs index b5edc703..5d53d2e4 100644 --- a/proxmox-rest-server/src/h2service.rs +++ b/proxmox-rest-server/src/h2service.rs @@ -16,6 +16,8 @@ use proxmox_router::{ApiResponseFuture, HttpError, Router, RpcEnvironment}; use crate::formatter::*; use crate::{WorkerTask, normalize_path_with_components}; +type LogFilterFn = Arc bool + Send + Sync>; + /// Hyper Service implementation to handle stateful H2 connections. /// /// We use this kind of service to handle backup protocol @@ -27,15 +29,23 @@ pub struct H2Service { rpcenv: E, worker: Arc, debug: bool, + log_filter: Option, } impl H2Service { - pub fn new(rpcenv: E, worker: Arc, router: &'static Router, debug: bool) -> Self { + pub fn new( + rpcenv: E, + worker: Arc, + router: &'static Router, + debug: bool, + log_filter: Option, + ) -> Self { Self { rpcenv, worker, router, debug, + log_filter, } } @@ -55,7 +65,14 @@ impl H2Service { Err(err) => return future::err(http_err!(BAD_REQUEST, "{}", err)).boxed(), }; - self.debug(format!("{method} {path}")); + if self + .log_filter + .clone() + .map(|filter| filter(&method, &path)) + .unwrap_or(true) + { + self.debug(format!("{method} {path}")); + } let mut uri_param = HashMap::new(); -- 2.47.3