From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 578851FF138 for ; Wed, 22 Jul 2026 12:18:11 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id D5DB6214B2; Wed, 22 Jul 2026 12:18:10 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox] pbs-api-types: reword outdated maintenance type docstrings Date: Wed, 22 Jul 2026 12:17:20 +0200 Message-ID: <20260722101720.141156-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784715427966 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.185 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YUBEVRMTTEX67WI65XFXMAJ5M7BW4CJ5 X-Message-ID-Hash: YUBEVRMTTEX67WI65XFXMAJ5M7BW4CJ5 X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: There are now more maintenance types than 'read-only' and 'offline'. Since listing them all is not really feasible anymore, do not explicitley mention the type variants in the docstring. Signed-off-by: Christian Ebner --- Note: This patch is intended as followup to https://lore.proxmox.com/pbs-devel/20260702145916.360488-1-r.obkircher@proxmox.com/ pbs-api-types/src/datastore.rs | 2 +- pbs-api-types/src/maintenance.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs index ccb7c748..b173c7f0 100644 --- a/pbs-api-types/src/datastore.rs +++ b/pbs-api-types/src/datastore.rs @@ -554,7 +554,7 @@ pub struct DataStoreConfig { #[serde(skip_serializing_if = "Option::is_none")] pub tuning: Option, - /// Maintenance mode, type is either 'offline' or 'read-only', message should be enclosed in " + /// Maintenance mode, message should be enclosed in " #[serde(skip_serializing_if = "Option::is_none")] pub maintenance_mode: Option, diff --git a/pbs-api-types/src/maintenance.rs b/pbs-api-types/src/maintenance.rs index 9469ed8b..99dffbee 100644 --- a/pbs-api-types/src/maintenance.rs +++ b/pbs-api-types/src/maintenance.rs @@ -77,7 +77,7 @@ serde_plain::derive_fromstr_from_deserialize!(MaintenanceType); #[derive(Deserialize, Serialize)] /// Maintenance mode pub struct MaintenanceMode { - /// Type of maintenance ("read-only" or "offline"). + /// Type of maintenance. #[serde(rename = "type")] pub ty: MaintenanceType, -- 2.47.3