From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id B3D741FF135 for ; Thu, 02 Jul 2026 17:00:54 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 844CB214C2; Thu, 02 Jul 2026 17:00:54 +0200 (CEST) From: Robert Obkircher To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox v2 05/13] pbs-api-types: add GarbageCollection maintenance mode Date: Thu, 2 Jul 2026 16:59:02 +0200 Message-ID: <20260702145916.360488-6-r.obkircher@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260702145916.360488-1-r.obkircher@proxmox.com> References: <20260702145916.360488-1-r.obkircher@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1783004415650 X-SPAM-LEVEL: Spam detection results: 0 DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2OV4SMQKOIM4JCO6UZRRIPULVR7FVMBU X-Message-ID-Hash: 2OV4SMQKOIM4JCO6UZRRIPULVR7FVMBU X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This mode may be used to safely prune and garbage collect a datastore without the risk of running out of space due to new backups. Signed-off-by: Robert Obkircher Reviewed-by: Christian Ebner Tested-by: Christian Ebner --- pbs-api-types/src/datastore.rs | 1 + pbs-api-types/src/maintenance.rs | 11 +++++++---- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs index 8450e69f..ccb7c748 100644 --- a/pbs-api-types/src/datastore.rs +++ b/pbs-api-types/src/datastore.rs @@ -649,6 +649,7 @@ impl DataStoreConfig { match current_type { Some(MaintenanceType::ReadOnly) => { /* always OK */ } + Some(MaintenanceType::GarbageCollection) => { /* always OK */ } Some(MaintenanceType::Offline) => { /* always OK */ } Some(MaintenanceType::Unmount) => { /* used to reset it after failed unmount, or alternative for aborting unmount task */ diff --git a/pbs-api-types/src/maintenance.rs b/pbs-api-types/src/maintenance.rs index 3815008a..9469ed8b 100644 --- a/pbs-api-types/src/maintenance.rs +++ b/pbs-api-types/src/maintenance.rs @@ -42,12 +42,11 @@ pub enum Operation { #[serde(rename_all = "kebab-case")] /// Maintenance type. pub enum MaintenanceType { - // TODO: - // - Add "GarbageCollection" or "DeleteOnly" as type and track GC (or all deletes) as separate - // operation, so that one can enable a mode where nothing new can be added but stuff can be - // cleaned /// Only read operations are allowed on the datastore. ReadOnly, + /// Allow reads and non-expanding writes, but disallow writes + /// that may increase storage usage. + GarbageCollection, /// Neither read nor write operations are allowed on the datastore. Offline, /// The datastore is being deleted. @@ -112,6 +111,10 @@ impl MaintenanceMode { (MaintenanceType::ReadOnly, Operation::Write | Operation::WriteNonExpanding) => { bail!("read-only maintenance mode: {}", message()) } + (MaintenanceType::GarbageCollection, Operation::Write) => { + bail!("garbage-collection maintenance mode: {}", message()) + } + (MaintenanceType::GarbageCollection, _) => Ok(()), #[cfg(feature = "enum-fallback")] (MaintenanceType::UnknownEnumValue(m), _) => bail!("unknown maintenance mode: {m}"), } -- 2.47.3