From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 9FC0C1FF135 for ; Thu, 02 Jul 2026 17:00:52 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 71381214AF; Thu, 02 Jul 2026 17:00:52 +0200 (CEST) From: Robert Obkircher To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox v2 04/13] pbs-api-types: add WriteNonExpanding datastore operation Date: Thu, 2 Jul 2026 16:59:01 +0200 Message-ID: <20260702145916.360488-5-r.obkircher@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260702145916.360488-1-r.obkircher@proxmox.com> References: <20260702145916.360488-1-r.obkircher@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1783004413379 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.000 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6CCNFCQDNL22SQV64FSG4V6BNOKKSY2T X-Message-ID-Hash: 6CCNFCQDNL22SQV64FSG4V6BNOKKSY2T X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The new variant will be used for Write operations that should be allowed in a new GarbageCollection maintenace mode. This name was chosen over "Prune" because it might also make sense to allow other administrative tasks that do not actually delete things. Signed-off-by: Robert Obkircher Reviewed-by: Christian Ebner Tested-by: Christian Ebner --- pbs-api-types/src/maintenance.rs | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/pbs-api-types/src/maintenance.rs b/pbs-api-types/src/maintenance.rs index a89001bb..3815008a 100644 --- a/pbs-api-types/src/maintenance.rs +++ b/pbs-api-types/src/maintenance.rs @@ -25,14 +25,16 @@ pub const MAINTENANCE_MESSAGE_SCHEMA: Schema = pub enum Operation { /// for any read operation like backup restore or RRD metric collection Read, - /// for any write/delete operation, like backup create or GC + /// for any read/write/delete operation, like backup create Write, + /// for read/write/delete operations that reduce or maintain + /// storage usage, like GC or prune. + WriteNonExpanding, /// for any purely logical operation on the in-memory state of the datastore, e.g., to check if /// some mutex could be locked (e.g., GC already running?) /// /// NOTE: one must *not* do any IO operations when only helding this Op state Lookup, - // GarbageCollect or Delete? } #[api] @@ -107,7 +109,7 @@ impl MaintenanceMode { (MaintenanceType::Offline, _) => bail!("offline maintenance mode: {}", message()), (MaintenanceType::S3Refresh, _) => bail!("S3 refresh maintenance mode: {}", message()), (MaintenanceType::ReadOnly, Operation::Read) => Ok(()), - (MaintenanceType::ReadOnly, Operation::Write) => { + (MaintenanceType::ReadOnly, Operation::Write | Operation::WriteNonExpanding) => { bail!("read-only maintenance mode: {}", message()) } #[cfg(feature = "enum-fallback")] -- 2.47.3