From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 3BC161FF135 for ; Thu, 02 Jul 2026 17:00:22 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 0A2CD21489; Thu, 02 Jul 2026 17:00:22 +0200 (CEST) From: Robert Obkircher To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox v2 03/13] pbs-api-types: deny non-lookup operations for unknown modes Date: Thu, 2 Jul 2026 16:59:00 +0200 Message-ID: <20260702145916.360488-4-r.obkircher@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260702145916.360488-1-r.obkircher@proxmox.com> References: <20260702145916.360488-1-r.obkircher@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1783004411154 X-SPAM-LEVEL: Spam detection results: 0 DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3PTJAEDHCFCFDVF2WXIAOF5VAIQYGZM5 X-Message-ID-Hash: 3PTJAEDHCFCFDVF2WXIAOF5VAIQYGZM5 X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Denying non-lookup operations for unknown modes is a safer default. This change should not affect anything because the backup server does not enable the enum-fallback feature. Signed-off-by: Robert Obkircher Tested-by: Christian Ebner --- pbs-api-types/src/maintenance.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pbs-api-types/src/maintenance.rs b/pbs-api-types/src/maintenance.rs index 9a1729f4..a89001bb 100644 --- a/pbs-api-types/src/maintenance.rs +++ b/pbs-api-types/src/maintenance.rs @@ -111,7 +111,7 @@ impl MaintenanceMode { bail!("read-only maintenance mode: {}", message()) } #[cfg(feature = "enum-fallback")] - (MaintenanceType::UnknownEnumValue(_), _) => Ok(()), + (MaintenanceType::UnknownEnumValue(m), _) => bail!("unknown maintenance mode: {m}"), } } } -- 2.47.3