From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 405F11FF14F for ; Wed, 17 Jun 2026 12:50:47 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1BD3B1E9B5; Wed, 17 Jun 2026 12:50:47 +0200 (CEST) From: Robert Obkircher To: pbs-devel@lists.proxmox.com Subject: [PATCH v1 proxmox 1/2] proxmox-sys: avoid unnecessary conversion in replace_file Date: Wed, 17 Jun 2026 12:49:53 +0200 Message-ID: <20260617105000.232928-2-r.obkircher@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260617105000.232928-1-r.obkircher@proxmox.com> References: <20260617105000.232928-1-r.obkircher@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781693355761 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 73IWBKZQGC3HFAADLF7ZO5CL2PBU5SCJ X-Message-ID-Hash: 73IWBKZQGC3HFAADLF7ZO5CL2PBU5SCJ X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Since make_tmp_file already returns a File there is no need to convert to a raw file descriptor and back. Fixes: 26c06df4 ("make_tmp_file: return File instead of Fd") Signed-off-by: Robert Obkircher --- proxmox-sys/src/fs/file.rs | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/proxmox-sys/src/fs/file.rs b/proxmox-sys/src/fs/file.rs index f0939381..533e0896 100644 --- a/proxmox-sys/src/fs/file.rs +++ b/proxmox-sys/src/fs/file.rs @@ -1,6 +1,6 @@ use std::fs::File; use std::io::{self, BufRead, BufReader, Write}; -use std::os::unix::io::{AsRawFd, FromRawFd, IntoRawFd}; +use std::os::unix::io::{AsRawFd, FromRawFd}; use std::path::{Path, PathBuf}; #[cfg(feature = "timer")] use std::time::Duration; @@ -177,9 +177,7 @@ pub fn replace_file>( options: CreateOptions, fsync: bool, ) -> Result<(), Error> { - let (fd, tmp_path) = make_tmp_file(&path, options)?; - - let mut file = unsafe { File::from_raw_fd(fd.into_raw_fd()) }; + let (mut file, tmp_path) = make_tmp_file(&path, options)?; if let Err(err) = file.write_all(data) { let _ = unistd::unlink(&tmp_path); -- 2.47.3