From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E8ACF1FF13B for ; Mon, 08 Jun 2026 11:00:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6F5D01765E; Mon, 8 Jun 2026 11:00:08 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup 1/2] proxy: scheduler: drop early return for keep-all prune jobs Date: Mon, 8 Jun 2026 10:59:18 +0200 Message-ID: <20260608085919.288332-2-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260608085919.288332-1-c.ebner@proxmox.com> References: <20260608085919.288332-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1780909129563 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.068 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox-backup-proxy.rs] Message-ID-Hash: HUUST7JBLMHMFG6GMWG22Y6HWBPBYGIE X-Message-ID-Hash: HUUST7JBLMHMFG6GMWG22Y6HWBPBYGIE X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: It is currently possible to configure a prune job without any keep options set, which will result in keeping all snapshots. The proxy does an early check for this, not even recalculating the schedule in that case and never creating any task. This caused some confusion as reported in the enterprise support, as the prune job reports pending state and is never executed if not triggered manually. Since it can make sense to create a scheduled job with keep-all for testing reasons, drop the early check so the configured schedule is honored, the task log containing the relevant info for the user on why no snapshots are being pruned. Signed-off-by: Christian Ebner --- src/bin/proxmox-backup-proxy.rs | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/bin/proxmox-backup-proxy.rs b/src/bin/proxmox-backup-proxy.rs index b372f779e..eb5443992 100644 --- a/src/bin/proxmox-backup-proxy.rs +++ b/src/bin/proxmox-backup-proxy.rs @@ -642,10 +642,6 @@ async fn schedule_datastore_prune_jobs() { continue; } - if !job_config.options.keeps_something() { - continue; // no 'keep' values set, keep all - } - let worker_type = "prunejob"; let auth_id = Authid::root_auth_id().clone(); if check_schedule(worker_type, &job_config.schedule, &job_id) { -- 2.47.3