From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup 1/2] proxy: scheduler: drop early return for keep-all prune jobs
Date: Mon, 8 Jun 2026 10:59:18 +0200 [thread overview]
Message-ID: <20260608085919.288332-2-c.ebner@proxmox.com> (raw)
In-Reply-To: <20260608085919.288332-1-c.ebner@proxmox.com>
It is currently possible to configure a prune job without any
keep options set, which will result in keeping all snapshots.
The proxy does an early check for this, not even recalculating the
schedule in that case and never creating any task. This caused some
confusion as reported in the enterprise support, as the prune job
reports pending state and is never executed if not triggered
manually.
Since it can make sense to create a scheduled job with keep-all for
testing reasons, drop the early check so the configured schedule is
honored, the task log containing the relevant info for the user on
why no snapshots are being pruned.
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
src/bin/proxmox-backup-proxy.rs | 4 ----
1 file changed, 4 deletions(-)
diff --git a/src/bin/proxmox-backup-proxy.rs b/src/bin/proxmox-backup-proxy.rs
index b372f779e..eb5443992 100644
--- a/src/bin/proxmox-backup-proxy.rs
+++ b/src/bin/proxmox-backup-proxy.rs
@@ -642,10 +642,6 @@ async fn schedule_datastore_prune_jobs() {
continue;
}
- if !job_config.options.keeps_something() {
- continue; // no 'keep' values set, keep all
- }
-
let worker_type = "prunejob";
let auth_id = Authid::root_auth_id().clone();
if check_schedule(worker_type, &job_config.schedule, &job_id) {
--
2.47.3
next prev parent reply other threads:[~2026-06-08 9:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 8:59 [PATCH proxmox-backup 0/2] schedule prunes even with keep-all Christian Ebner
2026-06-08 8:59 ` Christian Ebner [this message]
2026-06-08 8:59 ` [PATCH proxmox-backup 2/2] prune job: escalate keep-all from info to warning Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260608085919.288332-2-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox