From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id C1A731FF141 for ; Tue, 02 Jun 2026 15:01:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D069E1397A; Tue, 2 Jun 2026 15:01:09 +0200 (CEST) From: Robert Obkircher To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox 3/5] pbs-api-types: deny non-lookup operations for unknown modes Date: Tue, 2 Jun 2026 14:58:54 +0200 Message-ID: <20260602130001.217482-4-r.obkircher@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260602130001.217482-1-r.obkircher@proxmox.com> References: <20260602130001.217482-1-r.obkircher@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1780405201133 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: PULSCYIDZ2CUFHSGPFUV2RVWQUYXHPSD X-Message-ID-Hash: PULSCYIDZ2CUFHSGPFUV2RVWQUYXHPSD X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Denying non-lookup operations for unknown modes seems like a safer default. This change should not affect anything because the backup server does not enable the enum-fallback feature. Signed-off-by: Robert Obkircher --- pbs-api-types/src/maintenance.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pbs-api-types/src/maintenance.rs b/pbs-api-types/src/maintenance.rs index 7def498b..7e9599be 100644 --- a/pbs-api-types/src/maintenance.rs +++ b/pbs-api-types/src/maintenance.rs @@ -109,7 +109,7 @@ impl MaintenanceMode { bail!("read-only maintenance mode: {message}") } #[cfg(feature = "enum-fallback")] - (MaintenanceType::UnknownEnumValue(_), _) => Ok(()), + (MaintenanceType::UnknownEnumValue(m), _) => bail!("unknown maintenance mode: {m}"), } } } -- 2.47.3