From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1A9BB1FF146 for ; Tue, 12 May 2026 15:11:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B1CF3134FB; Tue, 12 May 2026 15:11:04 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup v3 2/7] datastore: GC: avoid double parsing of datastore tuning options Date: Tue, 12 May 2026 15:10:42 +0200 Message-ID: <20260512131047.689089-3-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260512131047.689089-1-c.ebner@proxmox.com> References: <20260512131047.689089-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778591344575 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.069 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [datastore.rs] Message-ID-Hash: X6OCS3L576GHLS6BNVHCPVFYNYMOSDJN X-Message-ID-Hash: X6OCS3L576GHLS6BNVHCPVFYNYMOSDJN X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The tuning options are currently parsed twice from the config during garbage collection. This is however not needed, the same unchanged config is used in both cases. Use the first parsed tuning option instance. Signed-off-by: Christian Ebner --- pbs-datastore/src/datastore.rs | 4 ---- 1 file changed, 4 deletions(-) diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs index 34efcd398..e39bdeb0a 100644 --- a/pbs-datastore/src/datastore.rs +++ b/pbs-datastore/src/datastore.rs @@ -2438,10 +2438,6 @@ impl DataStore { ); } - let tuning: DatastoreTuning = serde_json::from_value( - DatastoreTuning::API_SCHEMA - .parse_property_string(gc_store_config.tuning.as_deref().unwrap_or(""))?, - )?; let gc_cache_capacity = if let Some(capacity) = tuning.gc_cache_capacity { info!("Using chunk digest cache capacity of {capacity}."); capacity -- 2.47.3