From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8913D1FF146 for ; Tue, 12 May 2026 10:56:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6C4C79AE1; Tue, 12 May 2026 10:56:21 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup v2 1/4] datastore: restrict chunk store mutex scope to crate only Date: Tue, 12 May 2026 10:55:41 +0200 Message-ID: <20260512085544.255754-2-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260512085544.255754-1-c.ebner@proxmox.com> References: <20260512085544.255754-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778576035970 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.070 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2Y4OMK2O4I755A3RQXSEURSZQH2BWQIG X-Message-ID-Hash: 2Y4OMK2O4I755A3RQXSEURSZQH2BWQIG X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The mutex should never be used outside of the datastore implementation, all operations on it go through other method calls. Restrict the scope for the method to get the mutex. Signed-off-by: Christian Ebner --- changes since version 1: - no changes pbs-datastore/src/chunk_store.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pbs-datastore/src/chunk_store.rs b/pbs-datastore/src/chunk_store.rs index 68db88eab..2888dea39 100644 --- a/pbs-datastore/src/chunk_store.rs +++ b/pbs-datastore/src/chunk_store.rs @@ -423,7 +423,7 @@ impl ChunkStore { ProcessLocker::oldest_shared_lock(self.locker.clone().unwrap()) } - pub fn mutex(&self) -> &std::sync::Mutex<()> { + pub(crate) fn mutex(&self) -> &std::sync::Mutex<()> { &self.mutex } -- 2.47.3