From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 463221FF13F for ; Thu, 07 May 2026 15:02:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8FDDA1B6EE; Thu, 7 May 2026 15:02:02 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup v2 3/5] client: backup writer: pass no crypt config to manifest blob decoder Date: Thu, 7 May 2026 15:01:33 +0200 Message-ID: <20260507130135.589100-4-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260507130135.589100-1-c.ebner@proxmox.com> References: <20260507130135.589100-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778158810121 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.070 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6Z4UENX6FX5QKPDGFGR2XRKOOVMVKSWY X-Message-ID-Hash: 6Z4UENX6FX5QKPDGFGR2XRKOOVMVKSWY X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Data blobs storing a manifest are never encrypted, so passing the backup writer crypt config on DataBlob::decode() while fetching the previous manifest is useless, never used in that case anyways. Simply do not pass the crypt config to make the code semantically correct. No functional changes intended. Signed-off-by: Christian Ebner --- pbs-client/src/backup_writer.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pbs-client/src/backup_writer.rs b/pbs-client/src/backup_writer.rs index 49aff3fdd..47f08840e 100644 --- a/pbs-client/src/backup_writer.rs +++ b/pbs-client/src/backup_writer.rs @@ -745,8 +745,8 @@ impl BackupWriter { .await?; let blob = DataBlob::load_from_reader(&mut &raw_data[..])?; - // no expected digest available - let data = blob.decode(self.crypt_config.as_ref().map(Arc::as_ref), None)?; + // manifest blobs are never encrypted and no expected digest available + let data = blob.decode(None, None)?; let manifest = BackupManifest::from_data(&data[..], self.crypt_config.as_ref().map(Arc::as_ref))?; -- 2.47.3