From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 647731FF13C for ; Thu, 30 Apr 2026 17:06:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2640FE090; Thu, 30 Apr 2026 17:06:31 +0200 (CEST) From: Robert Obkircher To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox 2/3] pbs-abi-types: add GarbageCollection maintenance mode Date: Thu, 30 Apr 2026 17:05:40 +0200 Message-ID: <20260430150607.330413-3-r.obkircher@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260430150607.330413-1-r.obkircher@proxmox.com> References: <20260430150607.330413-1-r.obkircher@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777561488600 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.062 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3GFYZTAYQUC7X2LAGND2KKAFRQLQOCGF X-Message-ID-Hash: 3GFYZTAYQUC7X2LAGND2KKAFRQLQOCGF X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This mode may be used to safely prune and garbage collect a datastore without the risk of running out of space due to new backups. Signed-off-by: Robert Obkircher --- pbs-api-types/src/datastore.rs | 1 + pbs-api-types/src/maintenance.rs | 8 ++++---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs index 098d2b7c..47ae1819 100644 --- a/pbs-api-types/src/datastore.rs +++ b/pbs-api-types/src/datastore.rs @@ -635,6 +635,7 @@ impl DataStoreConfig { match current_type { Some(MaintenanceType::ReadOnly) => { /* always OK */ } + Some(MaintenanceType::GarbageCollection) => { /* always OK */ } Some(MaintenanceType::Offline) => { /* always OK */ } Some(MaintenanceType::Unmount) => { /* used to reset it after failed unmount, or alternative for aborting unmount task */ diff --git a/pbs-api-types/src/maintenance.rs b/pbs-api-types/src/maintenance.rs index 8a37756a..a46764bc 100644 --- a/pbs-api-types/src/maintenance.rs +++ b/pbs-api-types/src/maintenance.rs @@ -42,12 +42,10 @@ pub enum Operation { #[serde(rename_all = "kebab-case")] /// Maintenance type. pub enum MaintenanceType { - // TODO: - // - Add "GarbageCollection" or "DeleteOnly" as type and track GC (or all deletes) as separate - // operation, so that one can enable a mode where nothing new can be added but stuff can be - // cleaned /// Only read operations are allowed on the datastore. ReadOnly, + /// Allow reads and reclaim operations, but no new writes. + GarbageCollection, /// Neither read nor write operations are allowed on the datastore. Offline, /// The datastore is being deleted. @@ -116,6 +114,8 @@ impl MaintenanceMode { && matches!(operation, Operation::Write | Operation::Reclaim) { bail!("read-only maintenance mode: {}", message); + } else if self.ty == MaintenanceType::GarbageCollection && operation == Operation::Write { + bail!("garbage-collection maintenance mode: {}", message); } Ok(()) } -- 2.47.3