From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 24B161FF13C for ; Thu, 30 Apr 2026 17:06:30 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EC5ADDF78; Thu, 30 Apr 2026 17:06:29 +0200 (CEST) From: Robert Obkircher To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox 1/3] pbs-api-types: add datastore operation variant for reclaiming storage Date: Thu, 30 Apr 2026 17:05:39 +0200 Message-ID: <20260430150607.330413-2-r.obkircher@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260430150607.330413-1-r.obkircher@proxmox.com> References: <20260430150607.330413-1-r.obkircher@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777561486471 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.062 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: C3UJBUYL6TN6GX23MKGWK45R26LCFSLI X-Message-ID-Hash: C3UJBUYL6TN6GX23MKGWK45R26LCFSLI X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The Reclaim variant will be used for Write operations that should be allowed even when storage is almost full. Signed-off-by: Robert Obkircher --- pbs-api-types/src/maintenance.rs | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/pbs-api-types/src/maintenance.rs b/pbs-api-types/src/maintenance.rs index fc7d240d..8a37756a 100644 --- a/pbs-api-types/src/maintenance.rs +++ b/pbs-api-types/src/maintenance.rs @@ -25,14 +25,16 @@ pub const MAINTENANCE_MESSAGE_SCHEMA: Schema = pub enum Operation { /// for any read operation like backup restore or RRD metric collection Read, - /// for any write/delete operation, like backup create or GC + /// for any read/write/delete operation, like backup create Write, + /// for read/write/delete operations that reduce or maintain + /// storage usage, like GC or prune. + Reclaim, /// for any purely logical operation on the in-memory state of the datastore, e.g., to check if /// some mutex could be locked (e.g., GC already running?) /// /// NOTE: one must *not* do any IO operations when only helding this Op state Lookup, - // GarbageCollect or Delete? } #[api] @@ -110,7 +112,9 @@ impl MaintenanceMode { bail!("offline maintenance mode: {}", message); } else if self.ty == MaintenanceType::S3Refresh { bail!("S3 refresh maintenance mode: {}", message); - } else if self.ty == MaintenanceType::ReadOnly && Operation::Write == operation { + } else if self.ty == MaintenanceType::ReadOnly + && matches!(operation, Operation::Write | Operation::Reclaim) + { bail!("read-only maintenance mode: {}", message); } Ok(()) -- 2.47.3