From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 6F3501FF13C for ; Thu, 30 Apr 2026 11:21:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 25C5220C0C; Thu, 30 Apr 2026 11:21:23 +0200 (CEST) From: Robert Obkircher To: pbs-devel@lists.proxmox.com Subject: [PATCH v1 proxmox-backup 2/2] tree-wide: avoid struct-style debug representation of anyhow errors Date: Thu, 30 Apr 2026 11:17:44 +0200 Message-ID: <20260430092022.31857-3-r.obkircher@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260430092022.31857-1-r.obkircher@proxmox.com> References: <20260430092022.31857-1-r.obkircher@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777540751116 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.063 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: DN4HAIFRKDS66RCNI3SMZIMZJZPNQO4K X-Message-ID-Hash: DN4HAIFRKDS66RCNI3SMZIMZJZPNQO4K X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Print all causes in a single, colon-separated line instead of using the debug struct representation and no longer quote simple errors that don't have a context. Note that neither representation includes backtraces. Those are only displayed with ':?'. Signed-off-by: Robert Obkircher --- src/api2/admin/datastore.rs | 8 ++++---- src/server/pull.rs | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/api2/admin/datastore.rs b/src/api2/admin/datastore.rs index a814c076c..1e0a78f3a 100644 --- a/src/api2/admin/datastore.rs +++ b/src/api2/admin/datastore.rs @@ -470,7 +470,7 @@ pub async fn delete_snapshot( let snapshot = datastore.backup_dir(ns, backup_dir)?; datastore .delete_snapshot(&snapshot) - .map_err(|err| format_err!("failed to delete snapshot - {err:#?}"))?; + .map_err(|err| format_err!("failed to delete snapshot - {err:#}"))?; Ok(Value::Null) }) .await? @@ -1096,7 +1096,7 @@ pub fn prune( if !keep { if let Err(err) = datastore.delete_snapshot(backup_dir) { warn!( - "failed to remove dir {:?}: {err:#?}", + "failed to remove dir {:?}: {err:#}", backup_dir.relative_path() ); } @@ -1653,7 +1653,7 @@ pub fn upload_backup_log( datastore.add_blob(file_name.as_ref(), backup_dir, blob, &backend) }) .await - .map_err(|err| format_err!("{err:#?}"))??; + .map_err(|err| format_err!("{err:#}"))??; // fixme: use correct formatter Ok(formatter::JSON_FORMATTER.format_data(Value::Null, &*rpcenv)) @@ -2118,7 +2118,7 @@ pub fn set_group_notes( let backup_group = datastore.backup_group(ns, backup_group); datastore .set_group_notes(notes, backup_group) - .map_err(|err| format_err!("failed to set group notes - {err:#?}"))?; + .map_err(|err| format_err!("failed to set group notes - {err:#}"))?; Ok(()) } diff --git a/src/server/pull.rs b/src/server/pull.rs index 055a710fc..11a9a8ff9 100644 --- a/src/server/pull.rs +++ b/src/server/pull.rs @@ -1322,7 +1322,7 @@ async fn pull_group( log_sender .log( Level::WARN, - format!("Failed to collect reusable chunk from last backup: {err:#?}"), + format!("Failed to collect reusable chunk from last backup: {err:#}"), ) .await?; } -- 2.47.3