From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E4B851FF140 for ; Fri, 24 Apr 2026 13:24:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AA15D14813; Fri, 24 Apr 2026 13:24:56 +0200 (CEST) From: Hannes Laimer To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup] api: create target namespace when moving and it doesn't exist yet Date: Fri, 24 Apr 2026 13:24:20 +0200 Message-ID: <20260424112420.207317-1-h.laimer@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777029772620 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.080 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6GCZWKHYJDQFBJQE6R3OG4VEVK4RFWTS X-Message-ID-Hash: 6GCZWKHYJDQFBJQE6R3OG4VEVK4RFWTS X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: So the behaviour is the same what a normal `mv` would do. What still stays required is the existance of the parent to which the namespace is moved. Signed-off-by: Hannes Laimer --- noticed while doing some testing, though it works, i think having it create not-existing target namespaces makes sense pbs-datastore/src/datastore.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs index 6cb1c5ec..292c56bf 100644 --- a/pbs-datastore/src/datastore.rs +++ b/pbs-datastore/src/datastore.rs @@ -1200,8 +1200,9 @@ impl DataStore { if !self.namespace_exists(source_ns) { bail!("source namespace '{source_ns}' does not exist"); } - if !target_ns.is_root() && !self.namespace_exists(target_ns) { - bail!("target namespace '{target_ns}' does not exist"); + let target_parent = target_ns.parent(); + if !target_ns.is_root() && !self.namespace_exists(&target_parent) { + bail!("target parent namespace '{target_parent}' does not exist"); } if source_ns.contains(target_ns).is_some() { bail!( -- 2.47.3