From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id EF4B51FF143 for ; Sat, 11 Apr 2026 10:51:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4877D4DFA; Sat, 11 Apr 2026 10:52:12 +0200 (CEST) From: Thomas Lamprecht To: c.ebner@proxmox.com Subject: Re: [PATCH proxmox-backup v2 20/27] ui: expose assigning encryption key to sync jobs Date: Sat, 11 Apr 2026 10:02:13 +0200 Message-ID: <20260411085154.1961287-9-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260410165454.1578501-21-c.ebner@proxmox.com> References: <20260411085154.1961287-1-t.lamprecht@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775897455241 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NB4OKASFNK7R4FQYPICQ6CEGC2HJM2QH X-Message-ID-Hash: NB4OKASFNK7R4FQYPICQ6CEGC2HJM2QH X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pbs-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 10.04.26 um 18:54 schrieb Christian Ebner: > diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js > @@ -560,6 +561,35 @@ Ext.define('PBS.window.SyncJobEdit', { > > + { > + xtype: 'pbsEncryptionKeySelector', > + name: 'associated-key', > + fieldLabel: gettext('Associated Keys'), nit: for pull-only jobs the active key field is hidden, so the user only sees "Associated Keys" with no context. That label does not convey what the keys are for from a pull perspective. Maybe label it "Decryption Keys" when in pull direction? That matches the API param name and makes the purpose immediately clear. nit: the tab could also use a brief help text or tooltip explaining the active/associated key relationship and the automatic key retention on rotation, otherwise users will wonder what "associated" means.