From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 234E71FF143
	for <inbox@lore.proxmox.com>; Sat, 11 Apr 2026 10:51:55 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id C355751B8;
	Sat, 11 Apr 2026 10:52:40 +0200 (CEST)
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: c.ebner@proxmox.com
Subject: Re: [PATCH proxmox-backup v2 10/27] api: config: add endpoints for
 encryption key manipulation
Date: Sat, 11 Apr 2026 10:02:08 +0200
Message-ID: <20260411085154.1961287-4-t.lamprecht@proxmox.com>
X-Mailer: git-send-email 2.47.3
In-Reply-To: <20260410165454.1578501-11-c.ebner@proxmox.com>
References: <20260411085154.1961287-1-t.lamprecht@proxmox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1775897454850
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.001 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	RCVD_IN_VALIDITY_CERTIFIED_BLOCKED  0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	RCVD_IN_VALIDITY_RPBL_BLOCKED  0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	RCVD_IN_VALIDITY_SAFE_BLOCKED  0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: E4X32EBF6YH4F3VX4YUIRW4K27FVXAXV
X-Message-ID-Hash: E4X32EBF6YH4F3VX4YUIRW4K27FVXAXV
X-MailFrom: t.lamprecht@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
CC: pbs-devel@lists.proxmox.com
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pbs-devel-owner@lists.proxmox.com>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Subscribe: <mailto:pbs-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pbs-devel-leave@lists.proxmox.com>

Am 10.04.26 um 18:54 schrieb Christian Ebner:
> diff --git a/src/api2/config/encryption_keys.rs b/src/api2/config/encryption_keys.rs
> @@ -0,0 +1,203 @@
>
> +pub fn create_key(
> +    id: String,
> +    key: Option<String>,
> +    _rpcenv: &mut dyn RpcEnvironment,
> +) -> Result<KeyConfig, Error> {
> +    let key_config = if let Some(key) = &key {
> +        serde_json::from_str(key)
> +            .map_err(|err| format_err!("failed to parse provided key: {err}"))?
> +    } else {

nit: might want to do a trial decrypt here (like check_privs_and_load does) to
catch broken uploads early instead of only at first sync run.

> +fn encryption_key_in_use(id: &str) -> Result<Option<String>, Error> {
> +    let job_with_key = list.iter().find(|job| {

nit: this returns only the first matching job. Showing all affected jobs in the
error message would be nicer for the admin to repeatedly running into this for
each such job.