From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9741C1FF140 for ; Fri, 10 Apr 2026 17:43:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 74FF722120; Fri, 10 Apr 2026 17:44:29 +0200 (CEST) From: Thomas Lamprecht To: pbs-devel@lists.proxmox.com Subject: [PATCH v4 0/5] client: repository: add individual component parameters Date: Fri, 10 Apr 2026 16:09:01 +0200 Message-ID: <20260410154327.4133440-1-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775835763510 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.001 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3C5KT7BU2KKKP5SUQZDKNEBV3U6QKUBD X-Message-ID-Hash: 3C5KT7BU2KKKP5SUQZDKNEBV3U6QKUBD X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Follow-up to [v3], reworked based on Wolfgang's and Christian's review feedback - thx! The compact repository URL format ([[auth-id@]server[:port]:]datastore) can be cumbersome to work with when changing a single aspect of the connection or when using API tokens. This series adds --server, --port, --datastore, --auth-id, and --ns as separate CLI parameters alongside the existing compound --repository URL. Changes since [v3]: - Deduplicated mutual-exclusion check into check_mutual_exclusion() - Used AllOfSchema for mount.rs raw ApiMethod definitions - Commands where --ns is irrelevant (login, logout, version, status, GC, benchmark, task) now use BackupRepositoryArgs only - Moved optional_ns_param() to pbs-client tools as shared helper - Fixed change_backup_owner not stripping atom fields before forwarding - Small nits (anyhow::bail! -> bail!, private ENV_VAR_PBS_NAMESPACE) Changes since [v2]: - Deduplicated param resolution cascade into shared helper - Split into BackupRepositoryArgs and BackupTargetArgs (repo + ns) Changes since [v1]: - Split single commit into five - CLI atoms now merge with PBS_* env vars per-field (CLI wins) - Fixed mutual-exclusion error swallowing and duplicate ns property - PBS_NAMESPACE works uniformly across all three client binaries [v3]: https://lore.proxmox.com/pbs-devel/20260401225305.4069441-1-t.lamprecht@proxmox.com/ [v2]: https://lore.proxmox.com/pbs-devel/20260330182352.2346420-1-t.lamprecht@proxmox.com/ [v1]: https://lore.proxmox.com/pbs-devel/20260323211400.2661765-1-t.lamprecht@proxmox.com/ Thomas Lamprecht (5): client: repository: add tests for BackupRepository parsing client: repository: add individual component parameters client: migrate commands to flattened repository args docs: document repository component options and env vars fix #5340: client: repository: add PBS_NAMESPACE environment variable docs/backup-client.rst | 64 +++++ pbs-client/src/backup_repo.rs | 324 ++++++++++++++++++++++++- pbs-client/src/tools/mod.rs | 291 +++++++++++++++++++--- proxmox-backup-client/src/benchmark.rs | 8 +- proxmox-backup-client/src/catalog.rs | 26 +- proxmox-backup-client/src/group.rs | 14 +- proxmox-backup-client/src/main.rs | 104 ++++---- proxmox-backup-client/src/mount.rs | 130 +++++----- proxmox-backup-client/src/namespace.rs | 33 +-- proxmox-backup-client/src/snapshot.rs | 84 ++----- proxmox-backup-client/src/task.rs | 20 +- proxmox-file-restore/src/main.rs | 30 +-- src/bin/proxmox_backup_debug/diff.rs | 17 +- 13 files changed, 833 insertions(+), 312 deletions(-) -- 2.47.3