From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id EB4FF1FF13F for ; Thu, 09 Apr 2026 15:26:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4769D584C; Thu, 9 Apr 2026 15:27:35 +0200 (CEST) From: Lukas Wagner To: pdm-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com Subject: [PATCH proxmox{-backup,-mail-forward} 0/5] forward mails through notification worker; PDM compatibility Date: Thu, 9 Apr 2026 15:27:16 +0200 Message-ID: <20260409132721.272178-1-l.wagner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775741180142 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.053 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mod.rs,main.rs] Message-ID-Hash: BTLICFHCW2OHSXGWREX3ZQPJKWHD6SOG X-Message-ID-Hash: BTLICFHCW2OHSXGWREX3ZQPJKWHD6SOG X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Forwarding through the worker has a couple of benefits: - We don't need to bump proxmx-mail-forwarder for changes in proxmox-notify (at least as soon as PVE uses a similar approach as well) - any notification state (history, tokens) becomes easier to reason about if there is only one process touching it - we can move the Context trait implementations from proxmox_notify to the actual product code again Technically we'd need a versioned break between proxmox-backup and proxmox-mail-forward, due to the 'mail-forwarder' feature that was not enabled in PBS before, as well as the changed spool directory. If proxmox-mail-forward is updated without updating proxmox-backup, forwarding the mail would fail due to - /var/lib/proxmox-backup/notifications/queue not existing - proxmox-backup not being able to deserialize notifications of the 'Forwarded Mail' kind I don't think there is a way around this breakage, but we *could* defuse it by: - keep sending the old way (by directly calling into proxmox_notify) - but still change PBS to enable the 'mail-forwarder' feature and use the new spool-dir path - at some point in the future we switch proxmox-mail-forward to use the queue-based/worker approach, making it less likely that someone still holds back a proxmox-backup update, which would break forwarding I'll leave this decision to the PBS maintainers, just tell me which approach is preferrable, then I'll adapt the series if needed. proxmox-backup: Lukas Wagner (2): notifications: move spool directory to /var/lib/proxmox-backup/notifications/queue pull in 'mail-forwarder' feature for proxmox-notify Cargo.toml | 2 +- src/server/notifications/mod.rs | 30 ++++++++++++++++++++++++------ 2 files changed, 25 insertions(+), 7 deletions(-) proxmox-mail-forward: Lukas Wagner (3): forward using PBS' notification worker forward mails on PDM installations as well only ever forward for one product, favoring PVE over PBS over PDM Cargo.toml | 3 +- src/main.rs | 129 +++++++++++++++++++++++++++++----------------------- 2 files changed, 74 insertions(+), 58 deletions(-) Summary over all repositories: 4 files changed, 99 insertions(+), 65 deletions(-) -- Generated by murpp 0.11.0