From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 6B0D71FF144 for ; Tue, 24 Mar 2026 11:04:09 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A6453ACA7; Tue, 24 Mar 2026 11:04:29 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup] pbs-key-config: align fsync behavior when storing new/existing key Date: Tue, 24 Mar 2026 11:04:13 +0100 Message-ID: <20260324100413.215443-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774346617711 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.060 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 7ZAUM643PYYRLJNFZQ65DKGDEINOWYJX X-Message-ID-Hash: 7ZAUM643PYYRLJNFZQ65DKGDEINOWYJX X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: In case a key is stored by replacing the file contents, the file contents are synced to disk as the corresponding flag is set for proxmox-sys::fs::replace_file(). When creating a new file however, fsync is never called. Align the behaviour by also calling fsync in case of storing the key to a new file. Signed-off-by: Christian Ebner --- Noticed while evaluating to reuse this method to store key information to be used by push sync jobs. pbs-key-config/src/lib.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pbs-key-config/src/lib.rs b/pbs-key-config/src/lib.rs index 0bcd5338c..71a49dd78 100644 --- a/pbs-key-config/src/lib.rs +++ b/pbs-key-config/src/lib.rs @@ -1,5 +1,6 @@ use std::io::Write; use std::path::Path; +use std::os::fd::AsRawFd; use anyhow::{bail, format_err, Context, Error}; use serde::{Deserialize, Serialize}; @@ -254,6 +255,7 @@ impl KeyConfig { .open(path)?; file.write_all(data.as_bytes())?; + nix::unistd::fsync(file.as_raw_fd())?; } Ok(()) -- 2.47.3