From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7C10D1FF13C for ; Thu, 19 Mar 2026 12:03:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 455621B3C8; Thu, 19 Mar 2026 12:03:26 +0100 (CET) From: =?UTF-8?q?Michael=20K=C3=B6ppl?= To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup v2 2/3] fix #7400: api: gracefully handle corrupted job statefiles Date: Thu, 19 Mar 2026 12:03:17 +0100 Message-ID: <20260319110318.70346-3-m.koeppl@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260319110318.70346-1-m.koeppl@proxmox.com> References: <20260319110318.70346-1-m.koeppl@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773918157769 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.987 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 4VQXMOAJYNEJHQUJPVARO5VFYLTRX2LP X-Message-ID-Hash: 4VQXMOAJYNEJHQUJPVARO5VFYLTRX2LP X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Previously, if a job statefile was empty or corrupted (e.g. due to an I/O error or an abrupt shutdown), the JobStatus::load method would return an error that would be propagated up, causing the endpoint to return an error to the user, meaning users would not see any of their jobs if a single job had a corrupted statefile. Instead, handle the error explicitly, logging an error message and returning a default JobScheduleStatus such that jobs lists can still be fetched, displaying the affected job as configured but simply missing its last run status. Signed-off-by: Michael Köppl --- src/server/jobstate.rs | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/server/jobstate.rs b/src/server/jobstate.rs index cfb0b8945..638beac3e 100644 --- a/src/server/jobstate.rs +++ b/src/server/jobstate.rs @@ -305,8 +305,17 @@ pub fn compute_schedule_status( jobname: &str, schedule: Option<&str>, ) -> Result { - let job_state = JobState::load(jobtype, jobname) - .map_err(|err| format_err!("could not open statefile for {}: {}", jobname, err))?; + let job_state = match JobState::load(jobtype, jobname) { + Ok(job_state) => job_state, + Err(err) => { + log::error!( + "could not open statefile for {}: {} - falling back to default job schedule status", + jobname, + err + ); + return Ok(JobScheduleStatus::default()); + } + }; let (upid, endtime, state, last) = match job_state { JobState::Created { time } => (None, None, None, time), -- 2.47.3