From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8B5E21FF141 for ; Mon, 16 Mar 2026 15:19:33 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2F6151CB79; Mon, 16 Mar 2026 15:19:45 +0100 (CET) From: Hannes Laimer To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup v2] s3-client: fix Content-Type for put and copy object requests Date: Mon, 16 Mar 2026 15:19:40 +0100 Message-ID: <20260316141940.3576-1-h.laimer@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773670741668 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.078 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: HBSHFETMBXLQHI2RW4XHBZ6FCS6GIEBC X-Message-ID-Hash: HBSHFETMBXLQHI2RW4XHBZ6FCS6GIEBC X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Use the IANA registered `application/octet-stream` content type instead of the non-standard `binary/octet` value in put_object. Also set Content-Type explicitly in copy_object requests, since some S3 providers drop all source metadata, including Content-Type, when using x-amz-metadata-directive REPLACE unless it is explicitly provided. This caused s3_refresh to fail with "missing header 'content-type'" on such providers when fetching objects moved via copy_object. Setting it unconditionally is safe, since put_object already does the same. Signed-off-by: Hannes Laimer --- did notice this with RustFS, MinIO did not have that problem v2, thanks @Chris: - use `application/octet-stream` - also change to `application/octet-stream` in `put_object` proxmox-s3-client/src/client.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/proxmox-s3-client/src/client.rs b/proxmox-s3-client/src/client.rs index 413b3984..fbffe3e9 100644 --- a/proxmox-s3-client/src/client.rs +++ b/proxmox-s3-client/src/client.rs @@ -530,7 +530,7 @@ impl S3Client { let mut request = Request::builder() .method(Method::PUT) .uri(self.build_uri(&object_key, &[])?) - .header(header::CONTENT_TYPE, "binary/octet"); + .header(header::CONTENT_TYPE, "application/octet-stream"); if !replace { // Some providers not implement this and fails with error if the header is set, @@ -660,6 +660,7 @@ impl S3Client { .method(Method::PUT) .uri(self.build_uri(&destination_key, &[])?) .header("x-amz-copy-source", HeaderValue::from_str(©_source)?) + .header(header::CONTENT_TYPE, "application/octet-stream") .header( "x-amz-metadata-directive", HeaderValue::from_str("REPLACE")?, -- 2.47.3