From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 6B8901FF13F for ; Thu, 12 Mar 2026 15:31:47 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BA9861BAA8; Thu, 12 Mar 2026 15:31:43 +0100 (CET) From: Arthur Bied-Charreton To: pbs-devel@lists.proxmox.com Subject: [PATCH] fix #7337: Keep track of deep link on OpenID login Date: Thu, 12 Mar 2026 15:30:32 +0100 Message-ID: <20260312143032.409115-1-a.bied-charreton@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.094 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: OJ7OJITHNH55ZIU3GNZ7CIPSR5NG2LIS X-Message-ID-Hash: OJ7OJITHNH55ZIU3GNZ7CIPSR5NG2LIS X-MailFrom: abied-charreton@jett.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Previously, when opening a deep link without being logged into PBS, the hash was getting lost, redirecting the user to #pbsDashboard instead of /#. Store `window.location.hash` in sessionStorage (per-tab storage) before redirecting to the login URL, and add it to the history after successful login to direct the user to the deeplink they opened. `#pbsDashboard` remains the default redirect if no deeplink is stored. Signed-off-by: Arthur Bied-Charreton --- www/LoginView.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/www/LoginView.js b/www/LoginView.js index fd9594f6..b72e4223 100644 --- a/www/LoginView.js +++ b/www/LoginView.js @@ -48,6 +48,7 @@ Ext.define('PBS.LoginView', { if (this.getViewModel().data.openid === true) { const redirectURL = location.origin; + sessionStorage.setItem('openid-deeplink', location.hash); try { let resp = await Proxmox.Async.api2({ url: '/api2/extjs/access/openid/auth-url', @@ -217,7 +218,13 @@ Ext.define('PBS.LoginView', { let creds = response.result.data; PBS.Utils.updateLoginData(creds); PBS.app.changeView('mainview'); - history.replaceState(null, '', `${redirectURL}#pbsDashboard`); + let deeplink = sessionStorage.getItem('openid-deeplink'); + if (deeplink) { + sessionStorage.removeItem('openid-deeplink'); + history.replaceState(null, '', `${redirectURL}${deeplink}`); + } else { + history.replaceState(null, '', `${redirectURL}#pbsDashboard`); + } }, }); } -- 2.47.3