From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0CAC21FF13B for ; Wed, 11 Mar 2026 14:08:56 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AA8281A556; Wed, 11 Mar 2026 14:08:46 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox v5 12/13] pbs-api-types: add notification thresholds to datastore config Date: Wed, 11 Mar 2026 14:08:02 +0100 Message-ID: <20260311130823.724888-13-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260311130823.724888-1-c.ebner@proxmox.com> References: <20260311130823.724888-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773234482250 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: EB64LZZMXCVX3JJM4I5PPGZH3W4MOSUR X-Message-ID-Hash: EB64LZZMXCVX3JJM4I5PPGZH3W4MOSUR X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Allows to configure thresholds to be used to trigger notifications if exceeded. Defined independent from the backend config and tuning options as additional property string in the config, to keep flexibility and not further clutter the already present properties. Signed-off-by: Christian Ebner --- pbs-api-types/src/datastore.rs | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs index a2ff4a1d..c513d06f 100644 --- a/pbs-api-types/src/datastore.rs +++ b/pbs-api-types/src/datastore.rs @@ -11,6 +11,7 @@ use serde::{Deserialize, Serialize}; #[cfg(feature = "enum-fallback")] use proxmox_fixed_string::FixedString; +use proxmox_s3_client::RequestCounterThresholds; use proxmox_human_byte::HumanByte; use proxmox_schema::{ api, const_regex, ApiStringFormat, ApiType, ArraySchema, EnumEntry, IntegerSchema, ReturnType, @@ -474,6 +475,11 @@ impl FromStr for DatastoreBackendConfig { schema: DATASTORE_BACKEND_CONFIG_STRING_SCHEMA, optional: true, }, + "notification-thresholds": { + optional: true, + format: &ApiStringFormat::PropertyString(&RequestCounterThresholds::API_SCHEMA), + type: String, + }, } )] #[derive(Serialize, Deserialize, Updater, Clone, PartialEq)] @@ -531,6 +537,10 @@ pub struct DataStoreConfig { #[updater(skip)] #[serde(skip_serializing_if = "Option::is_none")] pub backend: Option, + + /// Threshold values for notifications + #[serde(skip_serializing_if = "Option::is_none")] + pub notification_thresholds: Option, } #[api] @@ -570,6 +580,7 @@ impl DataStoreConfig { maintenance_mode: None, backing_device: None, backend: None, + notification_thresholds: None, } } -- 2.47.3