From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 113A31FF144 for ; Tue, 10 Mar 2026 18:11:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 68F206655; Tue, 10 Mar 2026 18:11:50 +0100 (CET) Date: Tue, 10 Mar 2026 18:11:45 +0100 From: Stoiko Ivanov To: Robert Obkircher Subject: Re: [PATCH v1 proxmox-backup 0/3] fix incremental qemu backup Message-ID: <20260310181145.4198fe0b@rosa.proxmox.com> In-Reply-To: <20260310160537.182153-1-r.obkircher@proxmox.com> References: <20260310160537.182153-1-r.obkircher@proxmox.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773162671997 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.080 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: F2WZBEIO3ISOIQJRHZLZFQDK5JFNJ6RT X-Message-ID-Hash: F2WZBEIO3ISOIQJRHZLZFQDK5JFNJ6RT X-MailFrom: s.ivanov@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pbs-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks for quickly coming up with a patch. applying this series fixes the broken backups with qemu-vms we ran into today. Insofar consider this: Tested-by: Stoiko Ivanov On Tue, 10 Mar 2026 17:03:57 +0100 Robert Obkircher wrote: > Fix a bug, improve api docs, and disallow API usage that we don't need. > > Robert Obkircher (3): > api: backup: don't verify total file size for incremental backups > api: backup: improve schema documentation of fixed_close > api: backup: disallow incremental backups with different index length > > src/api2/backup/environment.rs | 14 +++++++------- > src/api2/backup/mod.rs | 15 ++++++++++++++- > 2 files changed, 21 insertions(+), 8 deletions(-) >