From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id D1FB01FF144 for ; Tue, 10 Mar 2026 17:10:01 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 23B5A487E; Tue, 10 Mar 2026 17:09:56 +0100 (CET) From: Robert Obkircher To: pbs-devel@lists.proxmox.com Subject: [PATCH v1 proxmox-backup 1/3] api: backup: don't verify total file size for incremental backups Date: Tue, 10 Mar 2026 17:03:58 +0100 Message-ID: <20260310160537.182153-2-r.obkircher@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260310160537.182153-1-r.obkircher@proxmox.com> References: <20260310160537.182153-1-r.obkircher@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773158929101 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.068 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3PVZGM7JTU5TQMJKAGNAJKST7LZSUTN3 X-Message-ID-Hash: 3PVZGM7JTU5TQMJKAGNAJKST7LZSUTN3 X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This fixes incremental qemu backups, where the submitted value is the upload size instead of the total size. Avoiding the check is preferable over breaking backwards compatability of the API because it was only relevant for detecting potential bugs. Signed-off-by: Robert Obkircher --- src/api2/backup/environment.rs | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/api2/backup/environment.rs b/src/api2/backup/environment.rs index 657daa41..ab623f1f 100644 --- a/src/api2/backup/environment.rs +++ b/src/api2/backup/environment.rs @@ -632,14 +632,14 @@ impl BackupEnvironment { ); } } - } - let writer_size = data.index.size(); - if size != writer_size { - bail!( - "fixed writer '{}' close failed - unexpected size ({size} != {writer_size})", - data.name, - ); + let writer_size = data.index.size(); + if size != writer_size { + bail!( + "fixed writer '{}' close failed - unexpected size ({size} != {writer_size})", + data.name, + ); + } } let expected_csum = data.index.close()?; -- 2.47.3