From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 61A4B1FF139 for ; Tue, 24 Feb 2026 10:13:33 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 082221F3E8; Tue, 24 Feb 2026 10:14:28 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox v3 01/10] proxmox-sys: expose msync to flush mmapped contents to filesystem Date: Tue, 24 Feb 2026 10:13:45 +0100 Message-ID: <20260224091406.169080-2-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260224091406.169080-1-c.ebner@proxmox.com> References: <20260224091406.169080-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771924446556 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.018 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_SHORT 0.001 Use of a URL Shortener for very short URL RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1.179 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.717 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.236 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NLIX67MUTYG5BGLIIGASFY25C3HASHYU X-Message-ID-Hash: NLIX67MUTYG5BGLIIGASFY25C3HASHYU X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Allows to flush all in-memory contents of the mmapped file back to the filesystem using msync [0] given the semantics provided via the `MS_*` flags. Without this the contents are not guaranteed to be persisted to the backing file until unmapped, which could lead to data loss on system crash or OOM situations. [0] https://man7.org/linux/man-pages/man2/msync.2.html Signed-off-by: Christian Ebner --- proxmox-sys/src/mmap.rs | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/proxmox-sys/src/mmap.rs b/proxmox-sys/src/mmap.rs index 8b8ad8a6..e15ca1db 100644 --- a/proxmox-sys/src/mmap.rs +++ b/proxmox-sys/src/mmap.rs @@ -56,6 +56,18 @@ impl Mmap { len: count, }) } + + /// Flush all in-memory contents to the backing file. + pub fn msync(&self, flags: mman::MsFlags) -> io::Result<()> { + unsafe { + mman::msync( + self.data.cast::(), + self.len * mem::size_of::(), + flags, + ) + } + .map_err(SysError::into_io_error) + } } impl std::ops::Deref for Mmap { -- 2.47.3