From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id ECD911FF13E for ; Fri, 20 Feb 2026 13:38:03 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A106D7B1D; Fri, 20 Feb 2026 13:38:54 +0100 (CET) From: Maximiliano Sandoval To: pbs-devel@lists.proxmox.com Subject: [PATCH backup v2 3/3] client: rename password to blob Date: Fri, 20 Feb 2026 13:38:16 +0100 Message-ID: <20260220123818.365489-4-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260220123818.365489-1-m.sandoval@proxmox.com> References: <20260220123818.365489-1-m.sandoval@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771591087859 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.085 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YR6FL3LGZC6BWV7NWERJNPE7BPBQ5YFO X-Message-ID-Hash: YR6FL3LGZC6BWV7NWERJNPE7BPBQ5YFO X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This is a Vec and not yet the password in its final form. Signed-off-by: Maximiliano Sandoval --- pbs-client/src/tools/mod.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pbs-client/src/tools/mod.rs b/pbs-client/src/tools/mod.rs index f28d9f32f..aa3ae94f2 100644 --- a/pbs-client/src/tools/mod.rs +++ b/pbs-client/src/tools/mod.rs @@ -167,8 +167,8 @@ fn get_secret_from_env(base_name: &str) -> Result, Error> { fn get_secret_impl(env_variable: &str, credential_name: &str) -> Result, Error> { if let Some(password) = get_secret_from_env(env_variable)? { Ok(Some(password)) - } else if let Some(password) = get_credential(credential_name)? { - str::from_utf8(&password) + } else if let Some(blob) = get_credential(credential_name)? { + str::from_utf8(&blob) .map(|s| { if matches!(credential_name, CRED_PBS_REPOSITORY | CRED_PBS_FINGERPRINT) { s.trim_end() -- 2.47.3