From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 2B4B81FF142 for ; Mon, 16 Feb 2026 13:13:39 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 90AFA106D2; Mon, 16 Feb 2026 13:14:24 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox v2 4/6] s3-client: account for upload traffic on successful request sending Date: Mon, 16 Feb 2026 13:13:52 +0100 Message-ID: <20260216121406.99617-5-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260216121406.99617-1-c.ebner@proxmox.com> References: <20260216121406.99617-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771244054418 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: IT42QXO6A4EQIP62HN3PIVHDITXSWPKU X-Message-ID-Hash: IT42QXO6A4EQIP62HN3PIVHDITXSWPKU X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: If the request could be send with success, account for uploaded traffic in the request counters. Do not account the traffic if the request could not be send completely. Signed-off-by: Christian Ebner --- changes since version 1: - use relaxed atomic ordering requirement proxmox-s3-client/src/client.rs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/proxmox-s3-client/src/client.rs b/proxmox-s3-client/src/client.rs index 731367cb..549fb904 100644 --- a/proxmox-s3-client/src/client.rs +++ b/proxmox-s3-client/src/client.rs @@ -435,6 +435,12 @@ impl S3Client { Ok(Ok(response)) => { if let Some(counters) = self.request_counters.as_ref() { let _prev = counters.increment(parts.method.clone(), Ordering::AcqRel); + let transferred: u64 = body_bytes + .len() + .try_into() + .context("failed to account for upload traffic")?; + let _prev_uploaded = + counters.add_upload_traffic(transferred, Ordering::AcqRel); } return Ok(response); -- 2.47.3