From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 81FF41FF142 for ; Mon, 16 Feb 2026 13:13:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6084A105FC; Mon, 16 Feb 2026 13:14:23 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox v2 1/6] shared-memory: add method without tmpfs check for mmap file location Date: Mon, 16 Feb 2026 13:13:49 +0100 Message-ID: <20260216121406.99617-2-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260216121406.99617-1-c.ebner@proxmox.com> References: <20260216121406.99617-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771244054214 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VYBZIFYWIRIM65QG4SZFQ3WDOBVWZ7GP X-Message-ID-Hash: VYBZIFYWIRIM65QG4SZFQ3WDOBVWZ7GP X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: For some usecases, e.g. s3 client request counters, the mmapped file should outlive a reboot and must therefore be placed on persistent storage, not just a tmpfs. Provide a dedicated method which does not perform the check, keeping the current interface untouched. Signed-off-by: Christian Ebner --- changes since version 1: - Keep pre-existing tmpfs check, provide dedicated methods for creating mmapped file on persistent storage instead. proxmox-shared-memory/src/lib.rs | 41 ++++++++++++++++++++++++++++++-- 1 file changed, 39 insertions(+), 2 deletions(-) diff --git a/proxmox-shared-memory/src/lib.rs b/proxmox-shared-memory/src/lib.rs index b067d1b9..da057366 100644 --- a/proxmox-shared-memory/src/lib.rs +++ b/proxmox-shared-memory/src/lib.rs @@ -80,7 +80,25 @@ fn mmap_file(file: &mut File, initialize: bool) -> Result, Erro } impl SharedMemory { + /// Open and mmap the file given at path, checking if the file resides on tmpfs. Further, + /// checks the size to be multiples of the page size. + /// Creates the file and path directories with given create options if they do not exist. pub fn open(path: &Path, options: CreateOptions) -> Result { + Self::open_impl(path, options, false) + } + + /// Open and mmap the file given at path, without checking if it is located on a tmpfs. + /// Checks the size to be multiples of the page size. + /// Creates the file and path directories with given create options if they do not exist. + pub fn open_non_tmpfs(path: &Path, options: CreateOptions) -> Result { + Self::open_impl(path, options, true) + } + + fn open_impl( + path: &Path, + options: CreateOptions, + skip_tmpfs_check: bool, + ) -> Result { let size = std::mem::size_of::(); let up_size = up_to_page_size(size); @@ -92,12 +110,31 @@ impl SharedMemory { ); } - let mmap = Self::open_shmem(path, options)?; + let mmap = Self::open_shmem_impl(path, options, skip_tmpfs_check)?; Ok(Self { mmap }) } + /// Open and mmap the file given at path, checking if the file resides on tmpfs. + /// Creates the file and path directories with given create options if they do not exist. pub fn open_shmem>(path: P, options: CreateOptions) -> Result, Error> { + Self::open_shmem_impl(path, options, false) + } + + /// Open and mmap the file given at path, without checking if it is located on a tmpfs. + /// Creates the file and path directories with given create options if they do not exist. + pub fn open_shmem_non_tmpfs>( + path: P, + options: CreateOptions, + ) -> Result, Error> { + Self::open_shmem_impl(path, options, true) + } + + fn open_shmem_impl>( + path: P, + options: CreateOptions, + skip_tmpfs_check: bool, + ) -> Result, Error> { let path = path.as_ref(); let dir_name = path @@ -105,7 +142,7 @@ impl SharedMemory { .ok_or_else(|| format_err!("bad path {:?}", path))? .to_owned(); - if !dir_name.ends_with("shmemtest") { + if !(dir_name.ends_with("shmemtest") || skip_tmpfs_check) { let statfs = nix::sys::statfs::statfs(&dir_name)?; if statfs.filesystem_type() != nix::sys::statfs::TMPFS_MAGIC { bail!("path {:?} is not on tmpfs", dir_name); -- 2.47.3