From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 609881FF13B for ; Wed, 11 Feb 2026 15:59:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2D81530FB6; Wed, 11 Feb 2026 15:59:52 +0100 (CET) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup] fix #7303: tape: handle NUL bytes in SCSI strings better Date: Wed, 11 Feb 2026 15:59:37 +0100 Message-ID: <20260211145947.645587-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: SGXT3QJBWGLTYI5GB2QZCFL5WHN3HPRS X-Message-ID-Hash: SGXT3QJBWGLTYI5GB2QZCFL5WHN3HPRS X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: When dealing with ASCII fields in answers from drives and changers, we assumed that the data is simply ascii characters padded by spaces, with potentially a NUL byte at the end. This is indicated for example by the IBM library documentation about the Primary Volume Tag Information[0]: ``` This is a 36 byte ASCII field that contains the cartridge bar code label, left-adjusted and padded on the right with blanks. ``` Some changers may reverse that though, and have a NUL terminated string followed by space padding (e.g. "FOO\0 "). When looking into the LTO-9 SCSI reference from IBM[1], they describe an ASCII field as follows: ``` When used to describe a field, indicates that the field contains only ASCII printable characters (i.e., code values 20h to 7Eh) and may be terminated with one or more ASCII null (00h) characters. ``` To be on the safe side here, limit the string to before the first NUL byte, and then trim the result. Added some tests to verify the desired behavior here. 0: https://www.ibm.com/docs/en/ts4500-tape-library/1.12.1?topic=storage-dvcidb0 1: https://www.ibm.com/support/pages/node/6490249 Signed-off-by: Dominik Csapak --- pbs-tape/src/sgutils2.rs | 44 ++++++++++++++++++++++++++++++++++++---- 1 file changed, 40 insertions(+), 4 deletions(-) diff --git a/pbs-tape/src/sgutils2.rs b/pbs-tape/src/sgutils2.rs index 6fec6ed5c..270420ce5 100644 --- a/pbs-tape/src/sgutils2.rs +++ b/pbs-tape/src/sgutils2.rs @@ -697,10 +697,12 @@ impl<'a, F: AsRawFd> SgRaw<'a, F> { /// Converts SCSI ASCII text into String, trim zero and spaces pub fn scsi_ascii_to_string(data: &[u8]) -> String { - String::from_utf8_lossy(data) - .trim_matches(char::from(0)) - .trim() - .to_string() + let mut view = data; + + if let Some(idx) = data.iter().position(|c| *c == 0u8) { + view = &view[..idx]; + } + String::from_utf8_lossy(view).trim().to_string() } /// Read SCSI Inquiry page @@ -1012,3 +1014,37 @@ pub fn scsi_request_sense(file: &mut F) -> Result